[Marble-devel] Review Request: Refactor route rendering colors: hardcoded --> config file

[Florian Eßer]

> On Dec. 7, 2011, 4:24 p.m., Bernhard Beschow wrote:
> > src/marble.kcfg, line 284
> > <http://git.reviewboard.kde.org/r/103314/diff/2/?file=42653#file42653line284>
> >
> >     In order to establish a "physical" connection to the code, you could change that line to:
> >     <default code="true">Marble::oxygenSkyBlue4</default>

cool! didn't know that trick...


- Florian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103314/#review8780
-----------------------------------------------------------


On Dec. 3, 2011, 2:29 p.m., Florian Eßer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103314/
> -----------------------------------------------------------
> 
> (Updated Dec. 3, 2011, 2:29 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Description
> -------
> 
> Based on the discussion from https://git.reviewboard.kde.org/r/102540/ this patch turns the hardcoded colors in the routing layer into softcoded colors and alpha values that are stored in the config files.
> 
> 
> Diffs
> -----
> 
>   src/QtMainWindow.cpp 1c24071 
>   src/lib/routing/RoutingLayer.cpp a5454ee 
>   src/lib/routing/RoutingManager.h dad9357 
>   src/lib/routing/RoutingManager.cpp 8488a56 
>   src/marble.kcfg 5f5dfa2 
>   src/marble_part.cpp 1bad437 
> 
> Diff: http://git.reviewboard.kde.org/r/103314/diff/diff
> 
> 
> Testing
> -------
> 
> Done for both KDE and Qt-only:
> * compile
> * start and close Marble --> default values are written to config file (Qt)
> * manually edit the config files (~/.kde/share/config/marblerc and ~/.config/kde.org/Marble Desktop Globe.conf) and add/change the colors and alpha values there
> * start Marble again --> route is rendered in different color
> 
> I could only test the default route color. I guess the other two are used while GPS navigating?
> 
> 
> Thanks,
> 
> Florian Eßer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20111207/cd2fe414/attachment.html>