[Marble-devel] Review Request: gpsd plugin: buffered values and position delay

[Bastian Holst]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102412/
-----------------------------------------------------------

(Updated Aug. 29, 2011, 9:31 p.m.)


Review request for Marble and Dennis Nienhüser.


Changes
-------

Fix for VERSION 3


Summary
-------

Playing with the navigation mode I recognized that the position is not up to date (using the gpsd plugin).
Looking at the code it seemed for me that the buffer of gpsmm is a queue so that we don't read the newest value.

This Patch takes the last valid one out of the buffer and returns it.


Diffs (updated)
-----

  src/plugins/positionprovider/gpsd/GpsdConnection.cpp c098ca2 

Diff: http://git.reviewboard.kde.org/r/102412/diff


Testing (updated)
-------

I ran around a littlebit and compared the values with the ones in xgps.

$ gpsd -V
gpsd: 2.95 (revision 2010-12-03T21:16:03)

GPSD_API_MAJOR_VERSION = 4
& with GPSD_API_MAJOR_VERSION = 3


Thanks,

Bastian

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20110829/3d8582cd/attachment.html>