[Marble-devel] Review Request: GeoDataLineString: ensure proper private handling
Thibaut Gridel
tgridel at free.fr
Tue Aug 16 18:19:38 UTC 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102342/
-----------------------------------------------------------
Review request for Marble.
Summary
-------
Ensure m_rangeCorrected is deep copied during private copy while detaching.
This avoids dangling pointers if both detached privates need to update that vector of pointers.
Thanks: Guillaume Martres for the test cases
Diffs
-----
src/lib/geodata/data/GeoDataGeometry_p.h 4bed8b6
src/lib/geodata/data/GeoDataLineString_p.h 4e87780
tests/TestGeoDataGeometry.cpp dca91d1
Diff: http://git.reviewboard.kde.org/r/102342/diff
Testing
-------
Thanks,
Thibaut
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20110816/2d30cfad/attachment.html>
More information about the Marble-devel
mailing list