[Marble-devel] Re: Review Request: Bookmarks and current location as routing input

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5485/#review7907
-----------------------------------------------------------

Ship it!


Looks good to me. Personally I'd think that ideally we'd have a lineedit which conveniently would provide the erase action as part of the edit field (since the clear action is certainly very common). But let's try how the menu solution works out. 

- Torsten


On 2010-09-29 21:01:44, Dennis Nienhüser wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5485/
> -----------------------------------------------------------
> 
> (Updated 2010-09-29 21:01:44)
> 
> 
> Review request for marble and Torsten Rahn.
> 
> 
> Summary
> -------
> 
> Changes the routing start/destination user interface:
> - Use one button instead of two ("remove" button on the right isn't perfect on Maemo)
> - Decouple the double-use of the left button ("map input" vs. "center map here")
> - Add the possibility to choose a bookmark or the current location as target position
> 
> The only drawback I see is that it adds a new menu, i.e. another click and less obvious interface. Another option would be to add a third button with a drop down like this which only has "from map", "bookmark" and "current location" as menu actions. But I'd rather not have three buttons given the rather restricted space we have.
> Please review with usability in mind ;-) and make sure to look at the screenshot, it should give a good overview of the changes.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/marble/src/lib/routing/RoutingWidget.cpp 1181012 
>   /trunk/KDE/kdeedu/marble/src/lib/routing/RoutingInputWidget.cpp 1181012 
>   /trunk/KDE/kdeedu/marble/src/lib/routing/RoutingInputWidget.h 1181012 
> 
> Diff: http://svn.reviewboard.kde.org/r/5485/diff
> 
> 
> Testing
> -------
> 
> Desktop version only so far, will test on Maemo later.
> 
> 
> Screenshots
> -----------
> 
> Routing Input GUI Changes
>   http://svn.reviewboard.kde.org/r/5485/s/516/
> 
> 
> Thanks,
> 
> Dennis
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20100930/66b335c2/attachment.htm