[Marble-devel] Re: Review Request: Inhibit screensaver in turn-by-turn navigation mode

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5167/#review7847
-----------------------------------------------------------

Ship it!


Ok, how should we proceed about this one? :)
I think it should be somehow marked as a workaround solution. But since it's a plugin and the awkwardness is restricted to it otherwise I'd give a go for the reason of user convenience.

- Torsten


On 2010-08-27 11:31:52, Dennis Nienhüser wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5167/
> -----------------------------------------------------------
> 
> (Updated 2010-08-27 11:31:52)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> In turn-by-turn navigation mode you usually just watch the screen, but do not "use" the system. A screensaver (screen blanking and locking on Maemo) coming in at that point is highly annoying. This patch adds an invisible render plugin that uses QtMobility to inhibit the screensaver as long as the plugin is enabled and a position provider is active. Given that it is a plugin on its own, the new dependency to QtMobility doesn't affect Marble much: Without QtMobility, the screensaver inhibition plugin is not build and its functionality isn't there, nothing else.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/marble/FindQtsysteminfo.cmake PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/graphicsview/ScreenGraphicsItem_p.h 1168534 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/CMakeLists.txt 1168534 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/inhibit-screensaver/CMakeLists.txt PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/inhibit-screensaver/InhibitScreensaverPlugin.h PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/inhibit-screensaver/InhibitScreensaverPlugin.cpp PRE-CREATION 
> 
> Diff: http://svn.reviewboard.kde.org/r/5167/diff
> 
> 
> Testing
> -------
> 
> Works on my N900.
> 
> 
> Thanks,
> 
> Dennis
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20100928/f56b2a72/attachment.htm