[Marble-devel] Re: Review Request: "Add Bookmark" context menu action

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5459/#review7827
-----------------------------------------------------------

Ship it!


Looks good to me -- the only essential thing that needs to be still added are the tr() calls ...


/trunk/KDE/kdeedu/marble/src/lib/BookmarkInfoDialog.h
<http://svn.reviewboard.kde.org/r/5459/#comment8096>

    Hm, is this class supposed to be part of the public API? If so then we should pimpl it ... :-(



/trunk/KDE/kdeedu/marble/src/lib/MarbleWidgetPopupMenu.cpp
<http://svn.reviewboard.kde.org/r/5459/#comment8097>

    tr() missing.



/trunk/KDE/kdeedu/marble/src/lib/MarbleWidgetPopupMenu.cpp
<http://svn.reviewboard.kde.org/r/5459/#comment8098>

    tr() missing.


- Torsten


On 2010-09-26 16:28:27, Dennis Nienhüser wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5459/
> -----------------------------------------------------------
> 
> (Updated 2010-09-26 16:28:27)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> The patch adds an "Add Bookmark" action to the default right mouse button popup menu next to the "Set Home Location" action. Just like that one, it uses the mouse position as the bookmark coordinate. Otherwise it behaves exactly like the "Add Bookmark" action from the main menu.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleWidgetPopupMenu.h 1179909 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleWidgetPopupMenu.cpp 1179909 
>   /trunk/KDE/kdeedu/marble/src/lib/BookmarkInfoDialog.cpp 1179909 
>   /trunk/KDE/kdeedu/marble/src/lib/BookmarkInfoDialog.h 1179909 
> 
> Diff: http://svn.reviewboard.kde.org/r/5459/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dennis
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20100926/aa82a03e/attachment.htm