[Marble-devel] Review Request: Fix KWorldClock plasmoid bug when using a localized version

Cristian Onet onet.cristian at gmail.com
Sun Sep 12 13:00:19 CEST 2010

This is an automatically generated e-mail. To reply, visit:

(Updated 2010-09-12 11:00:19.415945)

Review request for marble.


Remove link to b.k.o since it's handled by the 'Bugs' field of the review.

Summary (updated)

The BUG is caused by using a translated string as the value of m_locationkey (causing the invalid time) and not displaying the translated string when the time was correctly displayed on mouse hovering.
This patch fixes both issues by always using the english string for m_locationkey (which is used for computing the correct timezone) and displaying the translated string upon rendering (and font calculations).

The moving of the setProjection statement after setMapThemeId was done to fix a crash when calling setProjection due to the fact that d->m_mapTheme is null until setMapThemeId is called.

This addresses bug 240979.


  trunk/KDE/kdeedu/marble/src/plasmoid/worldclock.cpp 1174375 

Diff: http://svn.reviewboard.kde.org/r/5323/diff


Tested the scenario described in the bug report and it works as expected.



-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20100912/34989978/attachment.htm 

More information about the Marble-devel mailing list