[Marble-devel] Review Request: Add missing name attribute to GeoDataData

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5292/
-----------------------------------------------------------

Review request for marble.


Summary
-------

Our implementation of the kml Data element currently lacks the name attribute and uses the displayName instead, which is not correct. This leads to <Data> tags with empty name attributes being written if the (optional) displayName is not set.


Diffs
-----

  /trunk/KDE/kdeedu/marble/src/lib/BookmarkInfoDialog.cpp 1172715 
  /trunk/KDE/kdeedu/marble/src/lib/FileLoader.cpp 1172715 
  /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataData.h 1172715 
  /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataData.cpp 1172715 
  /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataData_p.h 1172715 
  /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataExtendedData.h 1172715 
  /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataExtendedData.cpp 1172715 
  /trunk/KDE/kdeedu/marble/src/lib/geodata/handlers/kml/KmlDataTagHandler.cpp 1172715 
  /trunk/KDE/kdeedu/marble/src/lib/geodata/writers/kml/KmlDataTagWriter.cpp 1172715 
  /trunk/KDE/kdeedu/marble/src/plugins/runner/gosmore/GosmoreRunner.cpp 1172715 
  /trunk/KDE/kdeedu/marble/src/plugins/runner/nominatim/OsmNominatimRunner.cpp 1172715 
  /trunk/KDE/kdeedu/marble/src/plugins/runner/routino/RoutinoRunner.cpp 1172715 

Diff: http://svn.reviewboard.kde.org/r/5292/diff


Testing
-------


Thanks,

Dennis

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20100908/5e8acbf4/attachment.htm