[Marble-devel] Review Request: GeoDataLineString KML tag writer

[Thibaut Gridel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5283/#review7466
-----------------------------------------------------------

Ship it!


not tested, looks good to me as early implementation of the basic linestring writer.

- Thibaut


On 2010-09-07 20:26:50, Dennis Nienhüser wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5283/
> -----------------------------------------------------------
> 
> (Updated 2010-09-07 20:26:50)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> Adds a kml tag writer for GeoDataLineString, adds writing of Document/name and Document/address elements and two convenience methods to write elements with string values quickly to reduce the amount of code.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/writer/GeoWriter.h 1172623 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/writer/GeoWriter.cpp 1172623 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/writers/kml/KmlDataTagWriter.cpp 1172623 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/writers/kml/KmlDocumentTagWriter.cpp 1172623 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/writers/kml/KmlFolderTagWriter.cpp 1172623 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/writers/kml/KmlLineStringTagWriter.h PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/writers/kml/KmlLineStringTagWriter.cpp PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/writers/kml/KmlLookAtTagWriter.cpp 1172623 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/writers/kml/KmlPlacemarkTagWriter.cpp 1172623 
> 
> Diff: http://svn.reviewboard.kde.org/r/5283/diff
> 
> 
> Testing
> -------
> 
> KML export of route requests and routes (intended for later automatic state saving/restoring).
> 
> 
> Thanks,
> 
> Dennis
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20100907/6526a6c0/attachment.htm