[Marble-devel] Review Request: Print Options

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5254/
-----------------------------------------------------------

Review request for marble.


Summary
-------

Extends the print dialog (X11 only, I'm afraid) with a new tab to configure Marble related print options: Toggle whether the map, the background (outer space), the legend, route summary and/or driving instructions are printed. The default values should be sane -- map is always checked by default, legend never. Background is not checked by default and is only enabled if the map does not cover the viewport. The routing options are checked if a route exists, and disabled otherwise.

Most of the code lies in ControlView to be used by the Qt and KDE version commonly. It may be possible to move it to MarbleWidget/MarbleModel to have it in the lib, but we need to agree on a way how to set the print options then.

The patch adds two new members to MarbleModel: The legend as a QTextDocument and a boolean controlling whether the background (background color =~ outer space and plugins like stars painting on it) is painted.


This addresses bug 241551.
    https://bugs.kde.org/show_bug.cgi?id=241551


Diffs
-----

  /trunk/KDE/kdeedu/marble/src/ControlView.h 1171700 
  /trunk/KDE/kdeedu/marble/src/ControlView.cpp 1171700 
  /trunk/KDE/kdeedu/marble/src/lib/CMakeLists.txt 1171700 
  /trunk/KDE/kdeedu/marble/src/lib/MarbleLegendBrowser.cpp 1171700 
  /trunk/KDE/kdeedu/marble/src/lib/MarbleModel.h 1171700 
  /trunk/KDE/kdeedu/marble/src/lib/MarbleModel.cpp 1171700 
  /trunk/KDE/kdeedu/marble/src/lib/MarbleWidget.cpp 1171700 
  /trunk/KDE/kdeedu/marble/src/lib/PrintOptions.ui PRE-CREATION 
  /trunk/KDE/kdeedu/marble/src/lib/PrintOptionsWidget.h PRE-CREATION 
  /trunk/KDE/kdeedu/marble/src/lib/PrintOptionsWidget.cpp PRE-CREATION 
  /trunk/KDE/kdeedu/marble/src/lib/routing/RoutingManager.h 1171700 
  /trunk/KDE/kdeedu/marble/src/lib/routing/RoutingManager.cpp 1171700 

Diff: http://svn.reviewboard.kde.org/r/5254/diff


Testing
-------

Globe without background and with legend: http://nienhueser.de/marble/marble-globe.pdf
Route with driving instructions: http://nienhueser.de/marble/marble-route.pdf


Screenshots
-----------

marble-print-options.png
  http://svn.reviewboard.kde.org/r/5254/s/495/


Thanks,

Dennis

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20100904/3c36f050/attachment.htm