[Marble-devel] Review Request: Position accuracy indicator

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/5168/
-----------------------------------------------------------

(Updated 2010-09-01 18:19:53.289959)


Review request for marble.


Changes
-------

This is an updated version of the diff intended for backporting. Please review (with ABI compatibility in mind).


Summary
-------

The position marker is a bit hard to spot on the N900 when there's only time for a quick glance at the screen. To improve that, this patch adds a half-transparent red circle at the current position. To give it a right to exist other than enhanced visibility, its size depends on the accuracy of the current position. The circle can be interpreted as "the device is pretty sure that the real position is within the colored circle". See the screenshot for an example with little confidence.


Diffs (updated)
-----

  /branches/KDE/4.5/kdeedu/marble/src/lib/geodata/data/GeoDataAccuracy.h 1170614 
  /branches/KDE/4.5/kdeedu/marble/src/lib/gps/PositionTracking.h 1170614 
  /branches/KDE/4.5/kdeedu/marble/src/lib/gps/PositionTracking.cpp 1170614 
  /branches/KDE/4.5/kdeedu/marble/src/plugins/positionprovider/gpsd/GpsdPositionProviderPlugin.cpp 1170614 
  /branches/KDE/4.5/kdeedu/marble/src/plugins/positionprovider/maemo/MaemoPositionProviderPlugin.cpp 1170614 

Diff: http://reviewboard.kde.org/r/5168/diff


Testing
-------

Works on my N900, no GPS mouse here currently to test it on my desktop system.


Screenshots
-----------


  http://reviewboard.kde.org/r/5168/s/490/


Thanks,

Dennis

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20100901/1e23ed68/attachment-0001.htm