[Marble-devel] Re: Review Request: Use the zoom buttons on the N900 to zoom in/out

Torsten Rahn rahn at kde.org
Fri Oct 15 16:00:38 CEST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5630/#review8163
-----------------------------------------------------------

Ship it!


Looks fine to me :-)

- Torsten


On 2010-10-14 17:10:04, Dennis Nienhüser wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5630/
> -----------------------------------------------------------
> 
> (Updated 2010-10-14 17:10:04)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> Disables the global volume control and uses the volume/zoom buttons of the N900 to zoom in/out of the map. Mainly posting this because of the #ifdef MAEMO's. I need it in the main window to add the actions to, so I can't move it to a plugin.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/marble/src/QtMainWindow.h 1185620 
>   /trunk/KDE/kdeedu/marble/src/QtMainWindow.cpp 1185620 
> 
> Diff: http://svn.reviewboard.kde.org/r/5630/diff
> 
> 
> Testing
> -------
> 
> Works on my N900.
> 
> 
> Thanks,
> 
> Dennis
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20101015/52800167/attachment.htm 


More information about the Marble-devel mailing list