[Marble-devel] Re: Review Request: Earthquake Online Service

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5995/#review9023
-----------------------------------------------------------


Marbleous patch :-) I like it and I think it could go in as is. All the comments I made below are just suggestions for further improvment :-)

Just wondering: Is the Tutorial you used to create the patch 100% correct? Or has anything changed that needs to be corrected in the Tutorial? If so it would be great if you could make corrections to the Tutorial (if you haven't done so already).

Again great work! Thanks a lot!


/trunk/KDE/kdeedu/marble/src/plugins/render/earthquake/EarthquakeItem.cpp
<http://svn.reviewboard.kde.org/r/5995/#comment9779>

    What about having different colors for different magnitude ranges:
    We could have
    
    Minor/Micro earthquakes in green
    Light earthquakes in yellow
    Moderate earthquakes in orange
    Strong-Epic earthquakes in red
    (all colors in oxygen palette of course)
    See
    
    http://en.wikipedia.org/wiki/Richter_magnitude_scale
    
    for categories.
    



/trunk/KDE/kdeedu/marble/src/plugins/render/earthquake/EarthquakeItem.cpp
<http://svn.reviewboard.kde.org/r/5995/#comment9778>

    Have you checked  how much time it takes to draw this SVG? Sometimes drawing SVGs takes quite some time.



/trunk/KDE/kdeedu/marble/src/plugins/render/earthquake/EarthquakeItem.cpp
<http://svn.reviewboard.kde.org/r/5995/#comment9780>

    Hm, would it be possible to have the date of the earthquake in addition? Maybe the date should be written below the symbol and the actual magnitude maybe on top of the symbol. Another thing that could be introduced as well would be a tooltip with more detailed information about the epicenter and the magnitude.
    
    I also wonder whether the magnitude wouldn't even look better like this:
    
    * Create outline text using QPainterPath
    * and use the darker pen color as defined above for the pen that draws the outline
    * and use a white brush for the color inside
    * and try bold for the font weight in addition :-)
    


- Torsten


On 2010-11-28 17:25:24, Dennis Nienhüser wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5995/
> -----------------------------------------------------------
> 
> (Updated 2010-11-28 17:25:24)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> The patch adds an online service that displays recent (up to one month ago) earthquake in the viewport.
> 
> Merely acting as a proxy for this review request: The patch is based on the excellent work of Utku Aydin in a Google Code-in task. I just added the seismograph background svg, changed the sort order to earthquake magnitude (i.e. the twenty earthquakes with highest magnitude are shown on the screen) and adjusted the code style to Marble's.
> 
> I'll delay the commit until 4.6 is branched off.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/CMakeLists.txt 1201749 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/earthquake/CMakeLists.txt PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/earthquake/EarthquakeItem.h PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/earthquake/EarthquakeItem.cpp PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/earthquake/EarthquakeModel.h PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/earthquake/EarthquakeModel.cpp PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/earthquake/EarthquakePlugin.h PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/earthquake/EarthquakePlugin.cpp PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/earthquake/earthquake.qrc PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/earthquake/seismograph.svg PRE-CREATION 
> 
> Diff: http://svn.reviewboard.kde.org/r/5995/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> Earthquake Plugin
>   http://svn.reviewboard.kde.org/r/5995/s/565/
> 
> 
> Thanks,
> 
> Dennis
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20101128/9d51f05d/attachment.htm