[Marble-devel] Re: Review Request: [Patch] Review Request for Bug 232098 - JJ: Please add fast adding messurment points by ctrl+click [MEDIUM]

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6003/#review9022
-----------------------------------------------------------


I don't think that this solution is appropriate (sorry ...):
First I don't think that the RMB menu is the right place to toggle between these modes. This kind of option feels like a convenience feature for power users. And the context menu isn't the right place for toggling this kind of stuff (also the length of the menu entry which tries to explain at length what it does is way too long for a context menu entry -- keep in mind that in other languages the translation is up to 3x as long as the english version). 

I see other possible solutions: 

* this kind of option could go into the Navigation settings dialog 
OR
* we introduce a real measurement mode (entered via a toggle toolbar buttongroup) where a single click already creates new measurement nodes
OR 
* we find a different modifier key for the creation of nodes for power-users

So no "Ship it" from me yet for the suggested solution.
 

- Torsten


On 2010-11-28 18:01:07, Thomas Lenarz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6003/
> -----------------------------------------------------------
> 
> (Updated 2010-11-28 18:01:07)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> I would like to propose a second patch for this junior job (Bug 232098: Fast adding of measure-points using ctrl+click).
> 
> It still uses the CTRL modifier key. However, "measure mode" has to be switched on via a new added menu toggle option within the right-mouse-button menu. This should avoid the conflict with the rubber-band-selection using the CTRL modifier key as well.
> When in "measure mode" the mouse-pointer changes to the "arrow-up"-pointer when CTRL is pressed to indicate the different behaviour.
> 
> Best wishes,
> 
> Thomas 
> 
> 
> This addresses bug 232098.
>     https://bugs.kde.org/show_bug.cgi?id=232098
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleWidgetInputHandler.cpp 1201666 
> 
> Diff: http://svn.reviewboard.kde.org/r/6003/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> fastmeasurement
>   http://svn.reviewboard.kde.org/r/6003/s/566/
> 
> 
> Thanks,
> 
> Thomas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20101128/724bd8e6/attachment-0001.htm