[Marble-devel] Re: Review Request: Unittest for GeoDataCoordinates-class.

[Matias Kallio]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5825/#review8864
-----------------------------------------------------------



/trunk/KDE/kdeedu/marble/tests/unittest_geodatacoordinates.cpp
<http://svn.reviewboard.kde.org/r/5825/#comment9502>

    Could you explain first of all what is the purpose of this normalize-methods? Where that functionality is needed? I have some difficulties to understand...
    
    Then shouldn't normalizeLon and normalizeLat produce similar output as normalizeLonLat? Because now I'm getting different values. Or Am I just doing something wrong:
    
    ****
    qreal lon = 200;
    qreal lat = 130;
    
    qDebug() << "lon" << GeoDataCoordinates::normalizeLon(lon, GeoDataCoordinates::Degree);
    qDebug() << "lat" << GeoDataCoordinates::normalizeLat(lat, GeoDataCoordinates::Degree);
    
    qreal normalized_lon = lon;
    qreal normalized_lat = lat;
    
    GeoDataCoordinates::normalizeLonLat( normalized_lon, normalized_lat, GeoDataCoordinates::Degree);
    qDebug() << "Normalize_lon " << normalized_lon << "normalize_lat " << normalized_lat;
    
    gives me:
    
    lon -160 
    lat 50 
    Normalize_lon  20 normalize_lat  50 
    ****


- Matias


On 2010-11-10 17:33:24, Matias Kallio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5825/
> -----------------------------------------------------------
> 
> (Updated 2010-11-10 17:33:24)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> First version of unittest for GeoDataCoordinates-class. 
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/marble/tests/CMakeLists.txt 1194752 
>   /trunk/KDE/kdeedu/marble/tests/unittest_geodatacoordinates.cpp PRE-CREATION 
> 
> Diff: http://svn.reviewboard.kde.org/r/5825/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matias
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20101120/8656cd95/attachment.htm