[Marble-devel] Re: Review Request: Unittest for GeoDataCoordinates-class.

[Bastian Holst]

> On 2010-11-10 20:57:54, Bastian Holst wrote:
> > This looks like a good start for a large set of unit tests.
> > However, all/most of these tests look like if they could make use of data driven tests:
> > http://doc.qt.nokia.com/4.7/qtestlib-tutorial2.html
> > These make it pretty easy to have one test with multiple instances.
> 
> Matias Kallio wrote:
>     Ok, thanks for the comments, you, Torsten and Dennis. I didn't remember that "Data Driven tests" at all. I think I'll take that in to use. 
>     
>     By the way, should there be some \tests\unittest-folder in the future?

This would be necessary if we had a number of unit tests and a reasonable number of other tests. At the moment we seem to have only unit tests and the MarbleWidgetSpeedTest so I don't think we need a special unittest folder for now.


- Bastian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5825/#review8647
-----------------------------------------------------------


On 2010-11-10 17:33:24, Matias Kallio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5825/
> -----------------------------------------------------------
> 
> (Updated 2010-11-10 17:33:24)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> First version of unittest for GeoDataCoordinates-class. 
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/marble/tests/CMakeLists.txt 1194752 
>   /trunk/KDE/kdeedu/marble/tests/unittest_geodatacoordinates.cpp PRE-CREATION 
> 
> Diff: http://svn.reviewboard.kde.org/r/5825/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matias
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20101111/716608e8/attachment.htm