[Marble-devel] Re: Review Request: Unittest for GeoDataCoordinates-class.

Bastian Holst bastianholst at gmx.de
Wed Nov 10 21:57:53 CET 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5825/#review8647
-----------------------------------------------------------


This looks like a good start for a large set of unit tests.
However, all/most of these tests look like if they could make use of data driven tests:
http://doc.qt.nokia.com/4.7/qtestlib-tutorial2.html
These make it pretty easy to have one test with multiple instances.

- Bastian


On 2010-11-10 17:33:24, Matias Kallio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5825/
> -----------------------------------------------------------
> 
> (Updated 2010-11-10 17:33:24)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> First version of unittest for GeoDataCoordinates-class. 
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/marble/tests/CMakeLists.txt 1194752 
>   /trunk/KDE/kdeedu/marble/tests/unittest_geodatacoordinates.cpp PRE-CREATION 
> 
> Diff: http://svn.reviewboard.kde.org/r/5825/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matias
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20101110/362a2485/attachment.htm 


More information about the Marble-devel mailing list