[Marble-devel] Re: Review Request: Unittest for GeoDataCoordinates-class.

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5825/#review8629
-----------------------------------------------------------



/trunk/KDE/kdeedu/marble/tests/unittest_geodatacoordinates.cpp
<http://svn.reviewboard.kde.org/r/5825/#comment9105>

    Maybe we should have a very short description for each test what is supposed to be tested? I don't know, what do the others say?



/trunk/KDE/kdeedu/marble/tests/unittest_geodatacoordinates.cpp
<http://svn.reviewboard.kde.org/r/5825/#comment9106>

    You're testing here whether the pointer is equal -- I guess it should be rather the value? 
    Another nitpick: I know that it doesn't actually matter in this case, but if you use degree values I think it would be nice to have GeoDataCoordinates::Degree used.



/trunk/KDE/kdeedu/marble/tests/unittest_geodatacoordinates.cpp
<http://svn.reviewboard.kde.org/r/5825/#comment9107>

    maybe just "long" as a name? Same for the others: "lat" instead of "lati" and "alt" instead of "alti" are common abbreviations.  
    
    Same for the rest of the document where these kind of variables appear again.


- Torsten


On 2010-11-10 17:33:24, Matias Kallio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5825/
> -----------------------------------------------------------
> 
> (Updated 2010-11-10 17:33:24)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> First version of unittest for GeoDataCoordinates-class. 
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/marble/tests/CMakeLists.txt 1194752 
>   /trunk/KDE/kdeedu/marble/tests/unittest_geodatacoordinates.cpp PRE-CREATION 
> 
> Diff: http://svn.reviewboard.kde.org/r/5825/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matias
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20101110/4c80890d/attachment.htm