[Marble-devel] Re: Review Request: Don't reverse geocode bookmark names for planets other than earth

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5781/#review8536
-----------------------------------------------------------


Ideally the runner manager itself decides not to run those plugins that can only work on earth: Once we get a plugin that does reverse geocoding for the moon, it would be disabled by this patch although it could deliver useful results. I'll look into why the runner manager does not get it right.


- Dennis


On 2010-11-07 11:09:51, Sebastian Wiedenroth wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5781/
> -----------------------------------------------------------
> 
> (Updated 2010-11-07 11:09:51)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> when adding a bookmark on the moon the name still gets reverse geocoded to a place on earth, this fixes it.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/marble/src/lib/BookmarkInfoDialog.cpp 1193657 
> 
> Diff: http://svn.reviewboard.kde.org/r/5781/diff
> 
> 
> Testing
> -------
> 
> tested adding bookmarks on earth and moon
> 
> 
> Thanks,
> 
> Sebastian
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20101107/e13d8f3b/attachment.htm