[Marble-devel] Review Request: Marble: GeoDataRegion safeness

Bastian Holst bastianholst at gmx.de
Fri May 7 15:25:06 CEST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3902/
-----------------------------------------------------------

(Updated 2010-05-07 13:25:06.402417)


Review request for marble and jmho.


Changes
-------

To prevent the usage of operator= it shouldn't be implemented.


Summary
-------

Making GeoDataRegion thread-safe and safe from self-assignment.

Thanks to jmho


Diffs (updated)
-----

  trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataRegion.h 1123751 
  trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataRegion.cpp 1123751 
  trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataRegion_p.h 1123751 

Diff: http://reviewboard.kde.org/r/3902/diff


Testing
-------


Thanks,

Bastian



More information about the Marble-devel mailing list