[Marble-devel] Review Request: add APRS data display to marble

[Wes Hardaker]

> On 2010-05-03 19:34:50, Dennis Nienhüser wrote:
> > trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsConfigWidget.ui, line 94
> > <http://reviewboard.kde.org/r/3843/diff/4/?file=25232#file25232line94>
> >
> >     Copy-and-paste tooltip?

Whoops; thanks.


> On 2010-05-03 19:34:50, Dennis Nienhüser wrote:
> > trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsConfigWidget.ui, line 156
> > <http://reviewboard.kde.org/r/3843/diff/4/?file=25232#file25232line156>
> >
> >     TCP/IP

Changed


> On 2010-05-03 19:34:50, Dennis Nienhüser wrote:
> > trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsConfigWidget.ui, line 185
> > <http://reviewboard.kde.org/r/3843/diff/4/?file=25232#file25232line185>
> >
> >     Copy-and-paste tooltip?

removed


> On 2010-05-03 19:34:50, Dennis Nienhüser wrote:
> > trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsConfigWidget.ui, line 243
> > <http://reviewboard.kde.org/r/3843/diff/4/?file=25232#file25232line243>
> >
> >     Copy-and-paste tooltip? :)

removed


> On 2010-05-03 19:34:50, Dennis Nienhüser wrote:
> > trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsObject.cpp, line 53
> > <http://reviewboard.kde.org/r/3843/diff/4/?file=25240#file25240line53>
> >
> >     unused variable

removed


> On 2010-05-03 19:34:50, Dennis Nienhüser wrote:
> > trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsFile.h, line 26
> > <http://reviewboard.kde.org/r/3843/diff/4/?file=25233#file25233line26>
> >
> >     could even be void now

I almost changed that in my last pass, but i was leaving it until I decided if I needed to return a sleep time instead; but i got around that so I've now changed it to void.


- Wes


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3843/#review5378
-----------------------------------------------------------


On 2010-05-01 00:35:36, Wes Hardaker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3843/
> -----------------------------------------------------------
> 
> (Updated 2010-05-01 00:35:36)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> Adds support for displaying HAM radio aprs data to the map pulled from three different possible sources.  The TCP/IP source is the default that is enabled and usable by everyone.  The others would require special sources and default to off.  The icons, which are binary files, can be found at:  http://www.hardakers.net/code/marble/aprs-icons.tar.gz
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdeedu/marble/data/CMakeLists.txt 1121250 
>   trunk/KDE/kdeedu/marble/src/plugins/render/CMakeLists.txt 1121250 
>   trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsConfigWidget.ui PRE-CREATION 
>   trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsFile.h PRE-CREATION 
>   trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsFile.cpp PRE-CREATION 
>   trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsGatherGen.pl PRE-CREATION 
>   trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsGatherer.h PRE-CREATION 
>   trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsGatherer.cpp PRE-CREATION 
>   trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsGatherer_mic_e.h PRE-CREATION 
>   trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsObject.h PRE-CREATION 
>   trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsObject.cpp PRE-CREATION 
>   trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsPlugin.h PRE-CREATION 
>   trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsPlugin.cpp PRE-CREATION 
>   trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsSource.h PRE-CREATION 
>   trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsSource.cpp PRE-CREATION 
>   trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsTCPIP.h PRE-CREATION 
>   trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsTCPIP.cpp PRE-CREATION 
>   trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsTTY.h PRE-CREATION 
>   trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsTTY.cpp PRE-CREATION 
>   trunk/KDE/kdeedu/marble/src/plugins/render/aprs/CMakeLists.txt PRE-CREATION 
>   trunk/KDE/kdeedu/marble/src/plugins/render/aprs/GeoAprsCoordinates.h PRE-CREATION 
>   trunk/KDE/kdeedu/marble/src/plugins/render/aprs/GeoAprsCoordinates.cpp PRE-CREATION 
>   trunk/KDE/kdeedu/marble/src/plugins/render/aprs/posix_qextserialport.cpp PRE-CREATION 
>   trunk/KDE/kdeedu/marble/src/plugins/render/aprs/qextserialport.h PRE-CREATION 
>   trunk/KDE/kdeedu/marble/src/plugins/render/aprs/qextserialport.cpp PRE-CREATION 
>   trunk/KDE/kdeedu/marble/src/plugins/render/aprs/qextserialport_global.h PRE-CREATION 
>   trunk/KDE/kdeedu/marble/src/plugins/render/aprs/win_qextserialport.cpp PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/3843/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> screenshot of california with data
>   http://reviewboard.kde.org/r/3843/s/378/
> 
> 
> Thanks,
> 
> Wes
> 
>