[Marble-devel] Review Request: Hide the rubber band if the mouse button is released above a float item

[Dennis Nienhüser]

> On 2010-03-30 17:49:46, Bastian Holst wrote:
> > This seems to be fixed, isn't it?

Yes, can be closed.


- Dennis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2270/#review4797
-----------------------------------------------------------


On 2009-11-23 15:58:22, Michael Hansen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2270/
> -----------------------------------------------------------
> 
> (Updated 2009-11-23 15:58:22)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> Currently, when the left mouse button is released above a float item while making a selection with ctrl+lmb, the rubber band is not hidden and sticks to the mouse cursor. Attempts to make a new selection fail, probably because the mouse is above the QRubberBand and not the map, therefore the eventFilter of Marble does not get any mouse-click-events.
> 
> The applied patch moves the code for the check for a released mouse button before the code that checks for float items below the mouse, therefore the rubber band can be released even when above a float item.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdeedu/marble/src/lib/MarbleWidgetInputHandler.cpp 1053185 
> 
> Diff: http://reviewboard.kde.org/r/2270/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael
> 
>