[Marble-devel] Review Request: Download Progress Indicator (Float Item)

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3858/
-----------------------------------------------------------

Review request for marble.


Summary
-------

On Maemo (and in applications embedding MarbleWidget) there is no status bar showing the progress bar. The patch adds a float item (default visible only on Maemo) that uses a little pie chart progress indicator to show download progress. It's only shown when downloads are progressing to avoid getting in the way (just like the progress bar in the status bar).


Diffs
-----

  /trunk/KDE/kdeedu/marble/src/plugins/render/CMakeLists.txt 1121413 
  /trunk/KDE/kdeedu/marble/src/plugins/render/progress/CMakeLists.txt PRE-CREATION 
  /trunk/KDE/kdeedu/marble/src/plugins/render/progress/ProgressFloatItem.h PRE-CREATION 
  /trunk/KDE/kdeedu/marble/src/plugins/render/progress/ProgressFloatItem.cpp PRE-CREATION 

Diff: http://reviewboard.kde.org/r/3858/diff


Testing
-------

Desktop and Scratchbox, download region feature and scrolling / zooming around.


Screenshots
-----------

marble-progress-pie.png
  http://reviewboard.kde.org/r/3858/s/384/


Thanks,

Dennis