[Marble-devel] Review Request: Don't iterate the float items on mouse move

[Bastian Holst]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2712/#review4796
-----------------------------------------------------------


You could add this line to the if statement, too:
&& !d->m_selectionRubber->isVisible()

- Bastian


On 2010-01-24 03:53:37, Ariya Hidayat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2712/
> -----------------------------------------------------------
> 
> (Updated 2010-01-24 03:53:37)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> Upon mouse move, iterating the float items (to see whether the input handler needs to process it or not) is not necessary. Therefore, let's do a quick culling before we enter the loop.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleWidgetInputHandler.cpp 1078350 
> 
> Diff: http://reviewboard.kde.org/r/2712/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ariya
> 
>