[Marble-devel] Review Request: move GeoDataTypes

Patrick Spendrin ps_ml at gmx.de
Mon Mar 29 21:58:46 CEST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3441/
-----------------------------------------------------------

Review request for marble.


Summary
-------

move the geodatatypes out of the public header into an own (private header) to make TestGeoData build and link again.


Diffs
-----

  trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataColorStyle.cpp 1108772 
  trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataContainer_p.h 1108772 
  trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataDocument_p.h 1108772 
  trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataFeature_p.h 1108772 
  trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataFolder.cpp 1108772 
  trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataGeometry_p.h 1108772 
  trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataHotSpot.cpp 1108772 
  trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataIconStyle.cpp 1108772 
  trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataLabelStyle.cpp 1108772 
  trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataLatLonAltBox.cpp 1108772 
  trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataLatLonBox.cpp 1108772 
  trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataLineString_p.h 1108772 
  trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataLineStyle.cpp 1108772 
  trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataLinearRing_p.h 1108772 
  trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataLod_p.h 1108772 
  trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataMultiGeometry_p.h 1108772 
  trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataObject.cpp 1108772 
  trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataPlacemark_p.h 1108772 
  trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataPoint.cpp 1108772 
  trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataPolyStyle.cpp 1108772 
  trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataPolygon_p.h 1108772 
  trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataRegion.cpp 1108772 
  trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataRegion_p.h 1108772 
  trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataStyle.cpp 1108772 
  trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataStyleMap.cpp 1108772 
  trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataStyleSelector.cpp 1108772 
  trunk/KDE/kdeedu/marble/src/lib/geodata/parser/GeoDataTypes.h PRE-CREATION 
  trunk/KDE/kdeedu/marble/src/lib/geodata/parser/GeoDataTypes.cpp PRE-CREATION 
  trunk/KDE/kdeedu/marble/src/lib/geodata/parser/GeoDocument.h 1108772 
  trunk/KDE/kdeedu/marble/src/lib/geodata/parser/GeoDocument.cpp 1108772 
  trunk/KDE/kdeedu/marble/src/lib/geodata/writers/kml/KmlDocumentTagWriter.cpp 1108772 
  trunk/KDE/kdeedu/marble/src/lib/geodata/writers/kml/KmlPlacemarkTagWriter.cpp 1108772 
  trunk/KDE/kdeedu/marble/src/lib/geodata/writers/kml/KmlPointTagWriter.cpp 1108772 
  trunk/KDE/kdeedu/marble/tests/CMakeLists.txt 1108772 
  trunk/KDE/kdeedu/marble/tests/TestGeoData.cpp 1108772 

Diff: http://reviewboard.kde.org/r/3441/diff


Testing
-------

msvc, works as expected.


Thanks,

Patrick



More information about the Marble-devel mailing list