[Marble-devel] ORS Routing fails because of lang "C"

Bastian Holst bastianholst at gmx.de
Tue Mar 23 16:05:26 CET 2010


Hi,

Thanks for spotting this bug. I committed i patch in revision 110661 [1].
It's a bit different from yours as you see.
It would be kind to know my patch fixes the problem for you, too.

Best regards
Bastian

[1] http://websvn.kde.org/?revision=1106661&view=revision

Am Samstag, 20. März 2010 20.13:06 schrieb Niko Sams:
> Hi,
> 
> I wanted to try marble's new routing feature but it didn't work
> because my locale is "C" and
> ors returned an error that this language is invalid.
> The patch below fixes it for me.
> (And I must say it works really great! I hope you will include all
> routing parameters avaliable for ors)
> 
> thanks,
> Niko
> 
> diff --git a/kdeedu/marble/src/lib/routing/OrsRoutingProvider.cpp
> b/kdeedu/marble/src/lib/routing/OrsRoutingProvider.cpp
> index e56aad9..1feb4cf 100644
> --- a/kdeedu/marble/src/lib/routing/OrsRoutingProvider.cpp
> +++ b/kdeedu/marble/src/lib/routing/OrsRoutingProvider.cpp
> @@ -82,7 +83,9 @@ QString OrsRoutingProvider::xmlHeader() const
>      result += "xsi:schemaLocation=\"http://www.opengis.net/xls ";
>      result += "http://schemas.opengis.net/ols/1.1.0/RouteService.xsd\"
> version=\"1.1\" xls:lang=\"%1\">\n";
>      result += "<xls:RequestHeader/>\n";
> -    return result.arg(MarbleLocale::languageCode());
> +    QString lang = MarbleLocale::languageCode();
> +    if (lang == "C") lang = "en";
> +    return result.arg(lang);
>  }
> 
>  QString OrsRoutingProvider::requestHeader(DistanceUnit unit,
> Preference preference) const
> _______________________________________________
> Marble-devel mailing list
> Marble-devel at kde.org
> https://mail.kde.org/mailman/listinfo/marble-devel
> 

-- 
10° 13' 41"O,  54° 24' 38"N
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/marble-devel/attachments/20100323/1105ff6f/attachment.sig 


More information about the Marble-devel mailing list