[Marble-devel] Review Request: Online-Routing using openrouteservice.org

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3034/#review4435
-----------------------------------------------------------



/trunk/KDE/kdeedu/marble/src/lib/routing/OrsRoutingProvider.h
<http://reviewboard.kde.org/r/3034/#comment3921>

    Hm, don't we have such an enum in global.h already? Why not use that one?



/trunk/KDE/kdeedu/marble/src/lib/routing/RoutingLayer.cpp
<http://reviewboard.kde.org/r/3034/#comment3922>

    let's use Oxygen colors here. See 
    
    http://www.oxygen-icons.org/?page_id=2
    
    the "normal" color set. E.g.:
    
    #2c72c7



/trunk/KDE/kdeedu/marble/src/lib/routing/RoutingLayer.cpp
<http://reviewboard.kde.org/r/3034/#comment3923>

    let's use Oxygen colors here. See 
    
    http://www.oxygen-icons.org/?page_id=2
    
    the "normal" color set.



/trunk/KDE/kdeedu/marble/src/lib/routing/RoutingLayer.cpp
<http://reviewboard.kde.org/r/3034/#comment3925>

    see above



/trunk/KDE/kdeedu/marble/src/lib/routing/RoutingLayer.cpp
<http://reviewboard.kde.org/r/3034/#comment3924>

    see above


- Torsten


On 2010-02-23 19:02:25, Dennis Nienhüser wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3034/
> -----------------------------------------------------------
> 
> (Updated 2010-02-23 19:02:25)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> Initial patch to support online routing in Marble. Currently uses openrouteservice.org, but support for other services is easy to add (yournavigation.org already included, but not used). It mainly consists of
> - A QAbstractItemModel to store the current route
> - An interactive paint layer that can show both placemarks (marble runner search results) and the current route. Input support for selecting route points containing instructions (shown as annotations), creating new via points (hover above current route, drag), moving start and destination. The paint layer behaves similar to a QAbstractItemView
> - A manager to initiate route downloading and updating
> - A widget providing input fields for routing trip points (using either MarbleRunnerManager to retrieve placemarks for search terms or picking locations from the map directly) and a list view to show route instructions or the marble runner result of the active input field
> 
> Some open todos are noted in the code, others in http://techbase.kde.org/Projects/Marble/OnlineRoutingImplementation .
> The icons missing in this patch can be downloaded at http://nienhueser.de/misc/marble-routing-icons.tar They are taken from or based on oxygen icons except progress.mng which I converted from a gif file generated by http://www.ajaxload.info/. Site states "Generated gifs are totally free for use" but if you have a better resource, please tell me.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/marble/data/bitmaps/progress.mng UNKNOWN 
>   /trunk/KDE/kdeedu/marble/data/bitmaps/routing_destination.png UNKNOWN 
>   /trunk/KDE/kdeedu/marble/data/bitmaps/routing_pick.png UNKNOWN 
>   /trunk/KDE/kdeedu/marble/data/bitmaps/routing_select.png UNKNOWN 
>   /trunk/KDE/kdeedu/marble/data/bitmaps/routing_start.png UNKNOWN 
>   /trunk/KDE/kdeedu/marble/data/bitmaps/routing_step.png UNKNOWN 
>   /trunk/KDE/kdeedu/marble/data/bitmaps/routing_via.png UNKNOWN 
>   /trunk/KDE/kdeedu/marble/src/lib/CMakeLists.txt 1093759 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleControlBox.cpp 1093759 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleRunnerManager.h 1093759 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleRunnerManager.cpp 1093759 
>   /trunk/KDE/kdeedu/marble/src/lib/libmarble.qrc 1093759 
>   /trunk/KDE/kdeedu/marble/src/lib/routing/AbstractRoutingProvider.h PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/routing/AbstractRoutingProvider.cpp PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/routing/OrsRoutingProvider.h PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/routing/OrsRoutingProvider.cpp PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/routing/RoutingInputWidget.h PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/routing/RoutingInputWidget.cpp PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/routing/RoutingLayer.h PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/routing/RoutingLayer.cpp PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/routing/RoutingManager.h PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/routing/RoutingManager.cpp PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/routing/RoutingModel.h PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/routing/RoutingModel.cpp PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/routing/RoutingProxyModel.h PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/routing/RoutingProxyModel.cpp PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/routing/RoutingWidget.h PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/routing/RoutingWidget.cpp PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/routing/RoutingWidget.ui PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/routing/YoursRoutingProvider.h PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/routing/YoursRoutingProvider.cpp PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/3034/diff
> 
> 
> Testing
> -------
> 
> Lots. Notice that you get an empty route when a) openrouteservice.org cannot be reached (network problems), b) a route trip point is not reachable (no streets nearby) or c) you're trying to retrieve a route outside of Europe.
> 
> 
> Screenshots
> -----------
> 
> marble-routing3.png
>   http://reviewboard.kde.org/r/3034/s/320/
> 
> 
> Thanks,
> 
> Dennis
> 
>