[Marble-devel] Review Request: More robust tile loading

[jensmh at gmx.de]

> On 2010-06-25 13:05:44, jmho wrote:
> > trunk/KDE/kdeedu/marble/src/lib/TextureTile.h, line 77
> > <http://reviewboard.kde.org/r/4444/diff/2/?file=29754#file29754line77>
> >
> >     Could not this stay a pointer also? It would prevent a QImage copy.
> 
> Bernhard Beschow wrote:
>     Since QImage is implicitly shared, copying is really fast. Here is a quote from the Qt documentation:
>     
>     "Implicitly shared classes are both safe and efficient when passed as arguments, because only a pointer to the data is passed around, and the data is copied only if and when a function writes to it, i.e., copy-on-write."
>     
>     This also means that if m_image is a value, QImage will do the memory management for us.
> 
> jmho wrote:
>     Sure, but
>     1) with pointers the code is easier to understand in this regard, that is one can easier see if a copy is a deep copy as there are much less copy operations
>     2) with a copy there is still the copy ctor executed, refernce counting done, etc
>
> 
> Bernhard Beschow wrote:
>     1) Why are there much less copy operations using a pointer? I'd say the number of deep copy operations are the same.
>     2) The copy constructor copies a pointer and increments the reference count. Given that this only happens after much more expensive operations like loading a tile from disk, do you really think that the additional increment of the reference count will impact performance?
> 
> jmho wrote:
>     re 1) I was referring to _all_ copy operations. I think it is clear that there are currently less than after applying the patch. What I meant is that counting the number of deep copy opterations is easier when there are not so much copy operations at all. I'm not saying we would have more deep copy operations with this patch applied. But understanding that would become harder as there were more places to review and think about.
>     re 2) no
>     
>     I might add that I changed a little bit in this area exactly with the goal of not invoking QImage's copy ctor, that is using QImage* where possible. So I'm not convinced that making the api a little bit more convient is worth it.
> 
> Torsten Rahn wrote:
>     Bernhard:
>     
>     1) When you pass a pointer around then you ensure that unintended copies are not created (since those copies would have a different pointer address).
> 
> Bernhard Beschow wrote:
>     Well, the rule is this: *Every* assignment creates a (virtual) copy. The gag is that a shallow copy is very cheap (comparable to copying a pointer) since a deep copy is delayed until somebody writes to it. In that case, only that somebody pays for the performance panelty. However, changing images behind TextureTile's back is very unclean and shall be made impossible with this patch.
>     
>     To sum it up, TextureTile will hold the data of an image which was present when it was assigned. If the image was modified afterwards, the TextureTile will hold the old data. This behavior is the same as for QString: If you modify a QString after you passed it to some label, the label will - of course - display the old text. This behavior is also called "value semantics".

I disagree with this part of the patch for the reason I explained above.


- jmho


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4444/#review6274
-----------------------------------------------------------


On 2010-06-25 12:49:24, Bernhard Beschow wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4444/
> -----------------------------------------------------------
> 
> (Updated 2010-06-25 12:49:24)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> Motivation: It may happen that Marble receives invalid image data over the network or loads invalid image data from disk, making Marble really slow. This is caused by heavy debug output from QImage while Marble tries to access invalid image data. This will be qFatal in the upcoming Qt 4.7.
> 
> Solution: Check if the image is valid ater loading data into a QImage instead of blindly loading data into it. Also Q_ASSERT every image assignment in TextureTile.
> 
> Note that by this patch, Marble will abort when TileLoader::scaledLowerLevelTile() is not able to produce a scaled image. This could happen when the level-zero tile is missing.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdeedu/marble/src/lib/TextureTile.h 1142673 
>   trunk/KDE/kdeedu/marble/src/lib/TextureTile.cpp 1142673 
>   trunk/KDE/kdeedu/marble/src/lib/TileLoader.h 1142673 
>   trunk/KDE/kdeedu/marble/src/lib/TileLoader.cpp 1142673 
> 
> Diff: http://reviewboard.kde.org/r/4444/diff
> 
> 
> Testing
> -------
> 
> Works for me. Please test if it works for you as well!
> 
> 
> Thanks,
> 
> Bernhard
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20100626/14e4ef5d/attachment.htm