[Marble-devel] Review Request: GeoData : Pointer Based GeoDataContainer

[1989.gaurav at gmail.com]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4441/
-----------------------------------------------------------

Review request for marble.


Summary
-------

Modified GeoDataContainer and converted it to hold Pointers to GeoDataFeature. Most of the feature working properly but getting some test failed.

When I insert a folder or placemark in a document all tests works fine but when placemarks are added into the folders in document I'm getting some failed tests. Please suggest me where I am going wrong.


Diffs
-----

  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/lib/FileManager.cpp 1140163 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataContainer.h 1140644 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataContainer.cpp 1140644 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataContainer_p.h 1140644 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataFolder.h 1140644 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataObject.h 1140644 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataObject.cpp 1140644 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataPlacemark.h 1140644 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/tests/TestGeoData.cpp 1140163 

Diff: http://reviewboard.kde.org/r/4441/diff


Testing
-------

run TestGeoData inside marble-build/tests/


Thanks,

1989gaurav

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20100623/0c404ea4/attachment.htm