[Marble-devel] Review Request: Make online menu use a renderType() function rather than a cast check

[Bastian Holst]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4410/#review6245
-----------------------------------------------------------

Ship it!


Looks good!

- Bastian


On 2010-06-21 18:28:27, Wes Hardaker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4410/
> -----------------------------------------------------------
> 
> (Updated 2010-06-21 18:28:27)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> This patch adds a renderType() function for determining the type of plugin it is and where the action() should be placed (eg, in the online menu).  Previously it was using a cast check and thus limited the types of actions that can be placed into the online menu to only things of a certain class tree.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdeedu/marble/src/QtMainWindow.cpp 1140837 
>   trunk/KDE/kdeedu/marble/src/lib/AbstractDataPlugin.h 1140837 
>   trunk/KDE/kdeedu/marble/src/lib/AbstractDataPlugin.cpp 1140837 
>   trunk/KDE/kdeedu/marble/src/lib/RenderPlugin.h 1140837 
>   trunk/KDE/kdeedu/marble/src/lib/RenderPlugin.cpp 1140837 
>   trunk/KDE/kdeedu/marble/src/marble_part.cpp 1140837 
> 
> Diff: http://reviewboard.kde.org/r/4410/diff
> 
> 
> Testing
> -------
> 
> Not much, since current SVN trunk crashes immediately on start up for me.  But it should be safe.
> 
> 
> Thanks,
> 
> Wes
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20100622/d8aa0774/attachment.htm