[Marble-devel] Review Request: GpsArrow plugin replaces PositionTracking drawing of the gps position

[Thibaut Gridel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4336/
-----------------------------------------------------------

(Updated 2010-06-16 21:59:10.850027)


Review request for marble.


Changes
-------

updated patch


Summary
-------

A new RenderPlugin to draw the gps position arrow instead of doing it in a specific way in PositionTracking and MarbleModel::paintGlobe.

Gps Track is deferred to GeometryModel, as the gps/ classes should go.

No more timer to cause updateGps, the position signal will trigger a repaintNeeded signal iff the position is visible


Diffs (updated)
-----

  /trunk/KDE/kdeedu/marble/src/MarbleTest.cpp 1136081 
  /trunk/KDE/kdeedu/marble/src/lib/MarbleDataFacade.h 1136081 
  /trunk/KDE/kdeedu/marble/src/lib/MarbleDataFacade.cpp 1136081 
  /trunk/KDE/kdeedu/marble/src/lib/MarbleMap.h 1136081 
  /trunk/KDE/kdeedu/marble/src/lib/MarbleMap.cpp 1136081 
  /trunk/KDE/kdeedu/marble/src/lib/MarbleModel.h 1136081 
  /trunk/KDE/kdeedu/marble/src/lib/MarbleModel.cpp 1136081 
  /trunk/KDE/kdeedu/marble/src/lib/MarbleWidget.h 1136081 
  /trunk/KDE/kdeedu/marble/src/lib/MarbleWidget.cpp 1136081 
  /trunk/KDE/kdeedu/marble/src/lib/Projections/AbstractProjection.h 1136081 
  /trunk/KDE/kdeedu/marble/src/lib/Projections/AbstractProjection.cpp 1136081 
  /trunk/KDE/kdeedu/marble/src/lib/gps/PositionTracking.h 1136081 
  /trunk/KDE/kdeedu/marble/src/lib/gps/PositionTracking.cpp 1136081 
  /trunk/KDE/kdeedu/marble/src/plugins/render/CMakeLists.txt 1136081 
  /trunk/KDE/kdeedu/marble/src/plugins/render/gps/CMakeLists.txt PRE-CREATION 
  /trunk/KDE/kdeedu/marble/src/plugins/render/gps/GpsArrow.h PRE-CREATION 
  /trunk/KDE/kdeedu/marble/src/plugins/render/gps/GpsArrow.cpp PRE-CREATION 

Diff: http://reviewboard.kde.org/r/4336/diff


Testing
-------

- using/unusing the plugin, 
- stopping/enabling gps tracks,
- panning arrow in/out of view,
- moving the map repaints the arrow at the new screen coordinates

The MarbleModel::showGps is losing some relevance here, as the plugin use/unuse replaces it somehow...


Thanks,

Thibaut