[Marble-devel] Review Request: Bookmark Feature Progress

[1989.gaurav at gmail.com]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4269/
-----------------------------------------------------------

(Updated 2010-06-09 18:31:25.774093)


Review request for marble.


Summary (updated)
-------

I have implemented most of the bookmarking and viewing. But It isn't working as expected. On startup it loads bookmark file MARBLE_DATA_PATH/bookmarks/bookmarks.kml and store it in a GeoDataDocument. On adding new bookmark, new node is appended in GeoDataDocument and bookmarks file is updated. On view GeoDataLookAt object is extracted and bookmark is shown using flyTo(GeoDataLookAt& ) method. 

File is getting modified properly, but flyTo is not working. run marble with --debug-info to print bookmark values added or read. Suggest me what could be the possible modifications.

It works only for Qt-Only version.


Diffs
-----

  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/data/CMakeLists.txt 1136009 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/data/bookmarks/bookmarks.kml PRE-CREATION 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/QtMainWindow.h 1136009 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/QtMainWindow.cpp 1136009 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/lib/BookmarkInfoDialog.h PRE-CREATION 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/lib/BookmarkInfoDialog.cpp PRE-CREATION 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/lib/BookmarkInfoDialog.ui PRE-CREATION 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/lib/BookmarkManager.h PRE-CREATION 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/lib/BookmarkManager.cpp PRE-CREATION 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/lib/BookmarkManager_p.h PRE-CREATION 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/lib/CMakeLists.txt 1136009 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/lib/MarbleModel.h 1136009 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/lib/MarbleModel.cpp 1136009 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/lib/MarbleWidget.h 1136009 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/lib/MarbleWidget.cpp 1136009 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataLookAt.h 1136009 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataLookAt.cpp 1136009 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataPlacemark.h 1136009 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataPlacemark.cpp 1136009 

Diff: http://reviewboard.kde.org/r/4269/diff


Testing
-------


Screenshots
-----------

bookmark feature
  http://reviewboard.kde.org/r/4269/s/429/


Thanks,

1989gaurav