[Marble-devel] Review Request: Bookmark Feature Progress

Torsten Rahn rahn at kde.org
Wed Jun 9 19:35:28 CEST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4269/#review6059
-----------------------------------------------------------



svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataPlacemark.cpp
<http://reviewboard.kde.org/r/4269/#comment5648>

    Without line 274 this would just become
    
    coordinateToLookAt->setCoordinates( coordinate() );



svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataPlacemark.cpp
<http://reviewboard.kde.org/r/4269/#comment5649>

    oh, this will probably not work:
    
    You basically set the range to zero here (since for most placemarks the height is close to zero.)
    
    Hm, we should use a useful default here.
    
    Maybe
    
    coordinateToLookAt->setRange( coordinates().altitude() + DEFAULT_RANGE );
    
    Where DEFAULT_RANGE would be a const with some good value (try maybe 1000).
    
    
    


- Torsten


On 2010-06-09 16:30:13, 1989gaurav wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4269/
> -----------------------------------------------------------
> 
> (Updated 2010-06-09 16:30:13)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> I have implemented most of the bookmarking and viewing. But It isn't working as expected. On startup it loads bookmark file MARBLE_DATA_PATH/bookmarks/bookmarks.kml and store it in a GeoDataDocument. On adding new bookmark, new node is appended in GeoDataDocument and bookmarks file is updated. On view GeoDataLookAt object is extracted and bookmark is shown using flyTo(GeoDataLookAt& ) method. 
> 
> File is getting modified properly, but flyTo is not working. run marble with --debug-info to print bookmark values added or read. Suggest me what could be the possible modifications.
> 
> 
> Diffs
> -----
> 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/data/CMakeLists.txt 1136009 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/data/bookmarks/bookmarks.kml PRE-CREATION 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/QtMainWindow.h 1136009 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/QtMainWindow.cpp 1136009 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/lib/BookmarkInfoDialog.h PRE-CREATION 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/lib/BookmarkInfoDialog.cpp PRE-CREATION 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/lib/BookmarkInfoDialog.ui PRE-CREATION 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/lib/CMakeLists.txt 1136009 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/lib/MarbleModel.h 1136009 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/lib/MarbleModel.cpp 1136009 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/lib/MarbleWidget.h 1136009 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/lib/MarbleWidget.cpp 1136009 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataLookAt.h 1136009 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataLookAt.cpp 1136009 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataPlacemark.h 1136009 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataPlacemark.cpp 1136009 
> 
> Diff: http://reviewboard.kde.org/r/4269/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> bookmark feature
>   http://reviewboard.kde.org/r/4269/s/429/
> 
> 
> Thanks,
> 
> 1989gaurav
> 
>



More information about the Marble-devel mailing list