[Marble-devel] Review Request: patch for i18n

[Bastian Holst]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4194/#review6036
-----------------------------------------------------------


Looks good in general, however there are some minor problems.


/trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataExtendedData.h
<http://reviewboard.kde.org/r/4194/#comment5626>

    Return the GeoDataData with the given @p key.



/trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataExtendedData.h
<http://reviewboard.kde.org/r/4194/#comment5625>

    Add a data object to the GeoDataExtendedData with the key @p.



/trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataExtendedData.h
<http://reviewboard.kde.org/r/4194/#comment5627>

    Could this comment please point out the difference between this and data().



/trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataExtendedData.h
<http://reviewboard.kde.org/r/4194/#comment5628>

    We should probably choose another name here. Perhaps dataReference or something like that.
    
    Perhaps we have something like that already. jmho talked about a similar topic some time ago iirc.



/trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataFeature_p.h
<http://reviewboard.kde.org/r/4194/#comment5629>

    Could you use spaces instead of tabs here?



/trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataFeature_p.h
<http://reviewboard.kde.org/r/4194/#comment5630>

    Could you use spaces instead of tabs here?



/trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataFeature_p.h
<http://reviewboard.kde.org/r/4194/#comment5631>

    Could you use spaces instead of tabs here?



/trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataFeature_p.h
<http://reviewboard.kde.org/r/4194/#comment5632>

    Could you use spaces instead of tabs here?


- Bastian


On 2010-06-07 10:32:19, hjain wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4194/
> -----------------------------------------------------------
> 
> (Updated 2010-06-07 10:32:19)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> This patch consists of KML handler and geodata classes for ExtendedData where custom data for Marble can be stored. This patch still requires to write code to use this data.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataData.h PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataData.cpp PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataData_p.h PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataExtendedData.h PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataExtendedData.cpp PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataExtendedData_p.h PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataFeature.h 1135207 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataFeature.cpp 1135207 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataFeature_p.h 1135207 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/handlers/kml/KmlDataTagHandler.h PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/handlers/kml/KmlDataTagHandler.cpp PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/handlers/kml/KmlDisplayNameTagHandler.h PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/handlers/kml/KmlDisplayNameTagHandler.cpp PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/handlers/kml/KmlElementDictionary.h 1135187 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/handlers/kml/KmlElementDictionary.cpp 1135187 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/handlers/kml/KmlExtendedDataTagHandler.h PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/handlers/kml/KmlExtendedDataTagHandler.cpp PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/handlers/kml/KmlValueTagHandler.h PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/handlers/kml/KmlValueTagHandler.cpp PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/parser/GeoDataTypes.h 1135187 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/parser/GeoDataTypes.cpp 1135187 
> 
> Diff: http://reviewboard.kde.org/r/4194/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> hjain
> 
>