[Marble-devel] Review Request: Bookmark feature

[1989.gaurav at gmail.com]

> On 2010-06-04 19:54:41, Dennis Nienhüser wrote:
> > svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/lib/BookmarkInfoDialog.cpp, line 30
> > <http://reviewboard.kde.org/r/4225/diff/1/?file=27904#file27904line30>
> >
> >     mDebug (four lines below as well)

done


> On 2010-06-04 19:54:41, Dennis Nienhüser wrote:
> > svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/lib/BookmarkInfoDialog.cpp, line 24
> > <http://reviewboard.kde.org/r/4225/diff/1/?file=27904#file27904line24>
> >
> >     m_saveButton and spaces missing

done, Can you give me link to the coding convention we follow. It will help me to remove these kind of mistakes in future.


- 1989gaurav


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4225/#review5985
-----------------------------------------------------------


On 2010-06-04 16:40:25, 1989gaurav wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4225/
> -----------------------------------------------------------
> 
> (Updated 2010-06-04 16:40:25)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> A Step towards Bookmark feature implementation.
> Added addBookmark button which shows longitude, latitude and zoom level on console.
> 
> 
> Diffs
> -----
> 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/QtMainWindow.h 1133781 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/QtMainWindow.cpp 1133781 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/lib/BookmarkInfoDialog.h PRE-CREATION 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/lib/BookmarkInfoDialog.cpp PRE-CREATION 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/lib/CMakeLists.txt 1133781 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/lib/PlacemarkInfoDialog.h 1133781 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/plugins/render/CMakeLists.txt 1133781 
> 
> Diff: http://reviewboard.kde.org/r/4225/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> 1989gaurav
> 
>