[Marble-devel] Review Request: 1/7 remove GpsLayer

[Thibaut Gridel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4210/
-----------------------------------------------------------

(Updated 2010-06-02 22:37:11.264489)


Review request for marble.


Changes
-------

sorry guys, RB is unable to understand a patch series, so I squashed all 7 patches in 1.

Here is an overview if you want to understand the way:

- MarbleModel gets the PositionTracking
- MarbleControlBox, MarbleMap and MarbleWidget use MarbleModel's PositionTraking instead of GpsLayer's
- dead code in MarbleMap and MarbleWidget about currentPosition in GpsLayer
- PositionTracking connects to PositionProvider to get the position updates directly. This separates drawing from position handling. I hope to have drawing without the need for MarbleModel::m_timer
- Lots of methods in MarbleMap and MarbleModel about showing Gps, start/stop polling
- Removing AbstractLayer and GpsLayer. Drawing is done in MarbleModel::paintGlobe (2 draw calls).

Regression: FileModel does not get cleaned anymore (it needs to go anyway in short term)


Summary
-------

patch 1 moves PositionTracking out of GpsLayer


Diffs (updated)
-----

  /trunk/KDE/kdeedu/marble/src/MarbleTest.cpp 1133912 
  /trunk/KDE/kdeedu/marble/src/lib/AbstractLayer/AbstractLayer.h 1133912 
  /trunk/KDE/kdeedu/marble/src/lib/AbstractLayer/AbstractLayer.cpp 1133912 
  /trunk/KDE/kdeedu/marble/src/lib/CMakeLists.txt 1133912 
  /trunk/KDE/kdeedu/marble/src/lib/MarbleControlBox.h 1133912 
  /trunk/KDE/kdeedu/marble/src/lib/MarbleControlBox.cpp 1133912 
  /trunk/KDE/kdeedu/marble/src/lib/MarbleMap.h 1133912 
  /trunk/KDE/kdeedu/marble/src/lib/MarbleMap.cpp 1133912 
  /trunk/KDE/kdeedu/marble/src/lib/MarbleModel.h 1133912 
  /trunk/KDE/kdeedu/marble/src/lib/MarbleModel.cpp 1133912 
  /trunk/KDE/kdeedu/marble/src/lib/MarbleWidget.h 1133912 
  /trunk/KDE/kdeedu/marble/src/lib/MarbleWidget.cpp 1133912 
  /trunk/KDE/kdeedu/marble/src/lib/gps/GpsLayer.h 1133912 
  /trunk/KDE/kdeedu/marble/src/lib/gps/GpsLayer.cpp 1133912 
  /trunk/KDE/kdeedu/marble/src/lib/gps/PositionTracking.h 1133912 
  /trunk/KDE/kdeedu/marble/src/lib/gps/PositionTracking.cpp 1133912 
  /trunk/KDE/kdeedu/marble/src/lib/gps/TrackSegment.cpp 1133912 

Diff: http://reviewboard.kde.org/r/4210/diff


Testing
-------

compiles and keeps gps handling:
- display arrow and track when gpsd selected
- hides when no source selected


Thanks,

Thibaut