[Marble-devel] Review Request: patch for i18n

[Bastian Holst]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4194/#review5958
-----------------------------------------------------------


In general I like your patch, but there are some minor issues.


/trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataData.cpp
<http://reviewboard.kde.org/r/4194/#comment5576>

    At the moment we have seperate files for the GeoData*Private classes



/trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataData.cpp
<http://reviewboard.kde.org/r/4194/#comment5577>

    Don't we need the GeoDataObject contructor here, too?



/trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataExtendedData.h
<http://reviewboard.kde.org/r/4194/#comment5578>

    A class which allows to add custom data to a KML Feature



/trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataExtendedData.h
<http://reviewboard.kde.org/r/4194/#comment5579>

    Is it?
    
    A GeoDataExtendedData provides access to a number of GeoDataData classes.



/trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataExtendedData.h
<http://reviewboard.kde.org/r/4194/#comment5580>

    Why do we need this?
    
    Ahh, again this thing, hm.



/trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataExtendedData.cpp
<http://reviewboard.kde.org/r/4194/#comment5583>

    Again, I'd like to see this in an extra file.



/trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataExtendedData.cpp
<http://reviewboard.kde.org/r/4194/#comment5581>

    missing spaces
    



/trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataExtendedData.cpp
<http://reviewboard.kde.org/r/4194/#comment5582>

    missing space



/trunk/KDE/kdeedu/marble/src/lib/geodata/handlers/kml/KmlValueTagHandler.h
<http://reviewboard.kde.org/r/4194/#comment5584>

    Upper case V


- Bastian


On 2010-06-02 07:27:08, hjain wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4194/
> -----------------------------------------------------------
> 
> (Updated 2010-06-02 07:27:08)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> This patch consists of KML handler and geodata classes for ExtendedData where custom data for Marble can be stored. This patch still requires to write code to use this data.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataExtendedData.h PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataData.h PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataData.cpp PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataExtendedData.cpp PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataFeature.h 1131227 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataFeature.cpp 1131227 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataFeature_p.h 1131227 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/handlers/kml/KmlDataTagHandler.h PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/handlers/kml/KmlDataTagHandler.cpp PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/handlers/kml/KmlDisplayNameTagHandler.h PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/handlers/kml/KmlDisplayNameTagHandler.cpp PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/handlers/kml/KmlElementDictionary.h 1131227 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/handlers/kml/KmlElementDictionary.cpp 1131227 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/handlers/kml/KmlExtendedDataTagHandler.h PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/handlers/kml/KmlExtendedDataTagHandler.cpp PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/handlers/kml/KmlValueTagHandler.h PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/handlers/kml/KmlValueTagHandler.cpp PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/4194/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> hjain
> 
>