[Marble-devel] Review Request: patch for i18n

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4194/#review5934
-----------------------------------------------------------



/trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataData.h
<http://reviewboard.kde.org/r/4194/#comment5556>

    void setValue( const QVariant & value );



/trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataData.h
<http://reviewboard.kde.org/r/4194/#comment5555>

    void setDisplayName( const QString & displayName );



/trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataExtendedData.h
<http://reviewboard.kde.org/r/4194/#comment5557>

    Why should we return by reference? Returning by reference is always a bit dangerously.



/trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataExtendedData.h
<http://reviewboard.kde.org/r/4194/#comment5558>

    void addData( const QString & key, const GeoDataData & data );



/trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataExtendedData.cpp
<http://reviewboard.kde.org/r/4194/#comment5559>

    Returning by reference is something that should get avoided unless there is a really good reason ...



/trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataFeature.h
<http://reviewboard.kde.org/r/4194/#comment5560>

    Avoid returning by reference.



/trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataFeature.h
<http://reviewboard.kde.org/r/4194/#comment5561>

    void setExtendedData( const GeoDataExtendedData & extendedData );


- Torsten


On 2010-06-01 14:01:00, hjain wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4194/
> -----------------------------------------------------------
> 
> (Updated 2010-06-01 14:01:00)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> This patch consists of KML handler and geodata classes for ExtendedData where custom data for Marble can be stored. This patch still requires to write code to use this data.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataData.h PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataData.cpp PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataExtendedData.h PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataExtendedData.cpp PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataFeature.h 1131227 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataFeature.cpp 1131227 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataFeature_p.h 1131227 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/handlers/kml/KmlDataTagHandler.h PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/handlers/kml/KmlDataTagHandler.cpp PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/handlers/kml/KmlDisplayNameTagHandler.h PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/handlers/kml/KmlDisplayNameTagHandler.cpp PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/handlers/kml/KmlElementDictionary.h 1131227 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/handlers/kml/KmlElementDictionary.cpp 1131227 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/handlers/kml/KmlExtendedDataTagHandler.h PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/handlers/kml/KmlExtendedDataTagHandler.cpp PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/handlers/kml/KmlValueTagHandler.h PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/handlers/kml/KmlValueTagHandler.cpp PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/4194/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> hjain
> 
>