[Marble-devel] Review Request: Marble: Geonames.org support

[hjain.itbhu at gmail.com]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4006/
-----------------------------------------------------------

(Updated 2010-06-01 06:51:23.023344)


Review request for marble.


Changes
-------

This patch contains modification in asc2kml.cpp file which does not write all placemarks with role PPLX in cityplacemarks.kml because these placemarks represents quarters instead of cities.
Kindly download this attachment and open it in marble folder :- http://uploading.com/files/b4aa931e/data.tar.gz/


Summary
-------

This patch is to use Geonames.org support for city placemarks. This patch also gives kml support for asciiname. Presently Marble is not generating cache for KML file. This issue is also solved.

Note:- It seems that there are more cities shown by default if you see the earth from far away


This addresses bugs 232261 and 232450.
    https://bugs.kde.org/show_bug.cgi?id=232261
    https://bugs.kde.org/show_bug.cgi?id=232450


Diffs (updated)
-----

  /trunk/KDE/kdeedu/marble/data/placemarks/HOWTO-cities.txt 1127478 
  /trunk/KDE/kdeedu/marble/src/lib/FileLoader.cpp 1127478 
  /trunk/KDE/kdeedu/marble/src/lib/MarbleDirs.cpp 1127478 
  /trunk/KDE/kdeedu/marble/src/lib/PlacemarkInfoDialog.cpp 1127478 
  /trunk/KDE/kdeedu/marble/src/lib/PlacemarkLayout.cpp 1127478 
  /trunk/KDE/kdeedu/marble/src/lib/PlacemarkManager.cpp 1127478 
  /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataFeature.h 1127478 
  /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataFeature.cpp 1127478 
  /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataFeature_p.h 1127478 
  /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataPlacemark.cpp 1127478 
  /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataPlacemark_p.h 1127478 
  /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataStyleMap.cpp 1127478 
  /trunk/KDE/kdeedu/marble/src/lib/geodata/handlers/kml/KmlRoleTagHandler.cpp 1127478 
  /trunk/KDE/kdeedu/marble/src/lib/geodata/parser/GeoDataTypes.h 1127478 
  /trunk/KDE/kdeedu/marble/src/lib/geodata/parser/GeoDataTypes.cpp 1127478 
  /trunk/KDE/kdeedu/marble/tools/asc2kml/asc2kml.cpp 1127478 

Diff: http://reviewboard.kde.org/r/4006/diff


Testing
-------


Thanks,

hjain