[Marble-devel] Review Request: Navigation Mode: Recentering, AutoZooming, showing routing instructions and map download for offline usage

Dennis Nienhüser earthwings at gentoo.org
Tue Jul 27 20:59:15 CEST 2010 

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4728/#review6717
-----------------------------------------------------------



/trunk/KDE/kdeedu/marble/src/lib/DownloadRegionDialog.cpp
<http://reviewboard.kde.org/r/4728/#comment6508>

    Something is wrong here, at least brackets and indentation are missing. May be merge leftovers.



/trunk/KDE/kdeedu/marble/src/lib/MarbleControlBox.cpp
<http://reviewboard.kde.org/r/4728/#comment6509>

    "MarbleDebug.h" instead of <MarbleDebug.h>



/trunk/KDE/kdeedu/marble/src/lib/MarbleControlBox.cpp
<http://reviewboard.kde.org/r/4728/#comment6510>

    mDebug() << "MarbleControlBox (sort): Time elapsed: " << t.elapsed() << " ms";



/trunk/KDE/kdeedu/marble/src/lib/PositionProviderPlugin.cpp
<http://reviewboard.kde.org/r/4728/#comment6511>

    return 0;



/trunk/KDE/kdeedu/marble/src/lib/PositionProviderPlugin.cpp
<http://reviewboard.kde.org/r/4728/#comment6512>

    return 0;



/trunk/KDE/kdeedu/marble/src/lib/TileCoordsPyramid.cpp
<http://reviewboard.kde.org/r/4728/#comment6513>

    Hm, why overload operator<< like this? Is it different to operator=?



/trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataLineString.cpp
<http://reviewboard.kde.org/r/4728/#comment6514>

    >= ?



/trunk/KDE/kdeedu/marble/src/lib/gps/PositionTracking.cpp
<http://reviewboard.kde.org/r/4728/#comment6515>

    should check whether there is a position provider for safety. See 
    QString PositionTracking::error() const



/trunk/KDE/kdeedu/marble/src/lib/gps/PositionTracking.cpp
<http://reviewboard.kde.org/r/4728/#comment6516>

    should check whether there is a position provider for safety. See 
    QString PositionTracking::error() const


- Dennis


On 2010-07-26 21:37:16, Siddharth Srivastava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4728/
> -----------------------------------------------------------
> 
> (Updated 2010-07-26 21:37:16)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> Added "Auto Recentering and Auto Zooming" support for navigation mode. Auto Recentering has two options: 
> (i) The current gps location is always at the center of the map (ii)The gps location is moved to the center of the map when required according to the custom area predefined according to the size of the map.
> 
> "Current Routing Instructions" are shown to the user while navigating through the route calculated. A plugin is added to show the time and distance remaining as well as the total distance covered on the route. When an instruction is selected the portion of the route where the instruction is valid gets highlighted. The instruction also appears a certain time before a user reaches it.
> 
> "Downloading of maps for offline mode" is implemented. For calculating the region to be downloaded an offset(in meters) around the calculated route and the required tile level ranges to be downloaded need to be specified. A default offset is used in case user doesn't specify any offset.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/marble/src/ControlView.h 1155009 
>   /trunk/KDE/kdeedu/marble/src/QtMainWindow.cpp 1155009 
>   /trunk/KDE/kdeedu/marble/src/lib/CMakeLists.txt 1155009 
>   /trunk/KDE/kdeedu/marble/src/lib/CurrentLocationWidget.ui 1155009 
>   /trunk/KDE/kdeedu/marble/src/lib/DownloadRegionDialog.h 1155009 
>   /trunk/KDE/kdeedu/marble/src/lib/DownloadRegionDialog.cpp 1155009 
>   /trunk/KDE/kdeedu/marble/src/lib/LatLonBoxWidget.ui 1155009 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleControlBox.h 1155009 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleControlBox.cpp 1155009 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleDataFacade.h 1155009 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleDataFacade.cpp 1155009 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleMap.h 1155009 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleMath.h 1155009 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleModel.h 1155009 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleModel.cpp 1155009 
>   /trunk/KDE/kdeedu/marble/src/lib/PositionProviderPlugin.h 1155009 
>   /trunk/KDE/kdeedu/marble/src/lib/PositionProviderPlugin.cpp 1155009 
>   /trunk/KDE/kdeedu/marble/src/lib/TileCoordsPyramid.h 1155009 
>   /trunk/KDE/kdeedu/marble/src/lib/TileCoordsPyramid.cpp 1155009 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataLineString.h 1155009 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataLineString.cpp 1155009 
>   /trunk/KDE/kdeedu/marble/src/lib/global.h 1155009 
>   /trunk/KDE/kdeedu/marble/src/lib/gps/PositionTracking.h 1155009 
>   /trunk/KDE/kdeedu/marble/src/lib/gps/PositionTracking.cpp 1155009 
>   /trunk/KDE/kdeedu/marble/src/lib/graphicsview/MarbleGraphicsItem.h 1155009 
>   /trunk/KDE/kdeedu/marble/src/lib/routing/AdjustNavigation.h PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/routing/AdjustNavigation.cpp PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/routing/RoutingLayer.cpp 1155009 
>   /trunk/KDE/kdeedu/marble/src/lib/routing/RoutingManager.h 1155009 
>   /trunk/KDE/kdeedu/marble/src/lib/routing/RoutingManager.cpp 1155009 
>   /trunk/KDE/kdeedu/marble/src/lib/routing/RoutingModel.h 1155009 
>   /trunk/KDE/kdeedu/marble/src/lib/routing/RoutingModel.cpp 1155009 
>   /trunk/KDE/kdeedu/marble/src/lib/routing/RoutingWidget.cpp 1155009 
>   /trunk/KDE/kdeedu/marble/src/plugins/positionprovider/gpsd/GpsdPositionProviderPlugin.h 1155009 
>   /trunk/KDE/kdeedu/marble/src/plugins/positionprovider/gpsd/GpsdPositionProviderPlugin.cpp 1155009 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/CMakeLists.txt 1155009 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/navigation/NavigationFloatItem.cpp 1155009 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/routing/CMakeLists.txt PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/routing/RoutingItemWidget.ui PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/routing/RoutingPlugin.h PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/routing/RoutingPlugin.cpp PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/plugins/runner/openrouteservice/OpenRouteServiceRunner.cpp 1155009 
>   /trunk/KDE/kdeedu/marble/tests/TestGeoData.cpp 1155009 
> 
> Diff: http://reviewboard.kde.org/r/4728/diff
> 
> 
> Testing
> -------
> 
> "Auto Recentering and Auto Zooming"- testing done on various gps tracks available. All possible combinations of Auto Zoom and the two modes of auto recentering were tested.
> "Current Routing Instructions" - testing done on various routes calculated using osmprovider as well as yoursnavigation provider and the gps tracks. Testing also done with and without plugin.
> "Downloading of maps for offline mode"- testing done for various routes around the world using orsprovider and yoursnavigation provider.
> 
> 
> Thanks,
> 
> Siddharth
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20100727/97225fa9/attachment-0001.htm

More information about the Marble-devel mailing list