[Marble-devel] Review Request: Displaying timezone information

[Thibaut Gridel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4729/#review6659
-----------------------------------------------------------



/trunk/KDE/kdeedu/marble/src/lib/MarblePlacemarkModel.h
<http://reviewboard.kde.org/r/4729/#comment6405>

    The name seems misleading. GMT is the mean time for Greenwich. Its timezone is by definition constantly 0 ;)
    
    I think you mean timezone instead.



/trunk/KDE/kdeedu/marble/src/lib/geodata/handlers/kml/KmlStateTagHandler.h
<http://reviewboard.kde.org/r/4729/#comment6404>

    state is a reserved attribute in kml reference for the "current state of the NetworkLink or Folder" it is an enum value!
    
    http://code.google.com/apis/kml/documentation/kmlreference.html#state
    
    You may want to use extended data instead.



/trunk/KDE/kdeedu/marble/src/lib/geodata/handlers/kml/KmlStateTagHandler.cpp
<http://reviewboard.kde.org/r/4729/#comment6402>

    Static cast would always return something. Please use .is which uses dynamic_cast and has a chance to return 0!


- Thibaut


On 2010-07-21 13:51:12, hjain wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4729/
> -----------------------------------------------------------
> 
> (Updated 2010-07-21 13:51:12)
> 
> 
> Review request for marble and Bastian Holst.
> 
> 
> Summary
> -------
> 
> This feature displays the timezone( gmt/dst ) and state of city placemarks in Placemark Info Dialog Box. This is partial patch. This patch does not changes in data/placemarks folder. Placemarks folder is uploaded at http://uploading.com/files/2b6d1bdf/placemarks.tar.gz/ 
> 
> Complete patch can be downloaded from http://uploading.com/files/719mmme6/timezone_final/
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/marble/src/lib/FileLoader.cpp 1152371 
>   /trunk/KDE/kdeedu/marble/src/lib/MarblePlacemarkModel.h 1152371 
>   /trunk/KDE/kdeedu/marble/src/lib/MarblePlacemarkModel.cpp 1152371 
>   /trunk/KDE/kdeedu/marble/src/lib/PlacemarkInfoDialog.cpp 1152371 
>   /trunk/KDE/kdeedu/marble/src/lib/PlacemarkInfoDialog.ui 1152371 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataPlacemark.h 1152371 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataPlacemark.cpp 1152371 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataPlacemark_p.h 1152371 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/handlers/kml/KmlStateTagHandler.h PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/handlers/kml/KmlStateTagHandler.cpp PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/tools/asc2kml/asc2kml.cpp 1152371 
> 
> Diff: http://reviewboard.kde.org/r/4729/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> hjain
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20100721/625a85e0/attachment.htm