[Marble-devel] Review Request: GeoData: showcase test for pointer-based GeoData

[Thibaut Gridel]

> On 2010-07-09 09:57:13, Bastian Holst wrote:
> > Your patch leads to too many cities to be shown on the globe.
> > See http://oculusaquilae.de/marble/too-many-cities.png

I found out this one is a side effect of appending the PositionTracking document to the FileManager, and might be considered a bug of PlacemarkLayout::paintPlaceFolder.
Indeed, the layout loop for placemark should stop at a certain popularity depending on altitude, and because PositionTracking adds a Placemark with undefined Popularity, the paintPlaceFolder assumes in:

         // Skip the places that are too small.
-        if ( !noFilter && m_weightfilter.at( popularityIndex ) > viewParams->radius() ) {
+        if ( m_weightfilter.at( popularityIndex ) > viewParams->radius() ) {
             break;
         }

That it should not do the proper popularity filtering because of that. This patch fixes the issue, and I will commit it soon afterwards.


- Thibaut


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4285/#review6438
-----------------------------------------------------------


On 2010-07-08 18:08:35, Thibaut Gridel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4285/
> -----------------------------------------------------------
> 
> (Updated 2010-07-08 18:08:35)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> providing a (naive) pointer-based api for GeoDataContainer, and test case which shows early breaks...
> 
> Toggle between the two "document.append(folder);" shows how brittle the api still is.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/marble/src/lib/CMakeLists.txt 1147288 
>   /trunk/KDE/kdeedu/marble/src/lib/FileLoader.cpp 1147288 
>   /trunk/KDE/kdeedu/marble/src/lib/FileManager.h 1147288 
>   /trunk/KDE/kdeedu/marble/src/lib/FileManager.cpp 1147288 
>   /trunk/KDE/kdeedu/marble/src/lib/GeoDataTreeModel.h PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/GeoDataTreeModel.cpp PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/KmlFileViewItem.h 1147288 
>   /trunk/KDE/kdeedu/marble/src/lib/KmlFileViewItem.cpp 1147288 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleDataFacade.h 1147288 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleDataFacade.cpp 1147288 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleGeometryModel.h 1147288 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleGeometryModel.cpp 1147288 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleModel.cpp 1147288 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataContainer.h 1147288 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataContainer.cpp 1147288 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataContainer_p.h 1147288 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataFeature.h 1147288 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataFolder.h 1147288 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataGeometry.h 1147288 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataMultiGeometry.h 1147288 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataMultiGeometry.cpp 1147288 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataMultiGeometry_p.h 1147288 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataObject.h 1147288 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataObject.cpp 1147288 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataPlacemark.h 1147288 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataPlacemark.cpp 1147288 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/writers/kml/KmlDocumentTagWriter.cpp 1147288 
>   /trunk/KDE/kdeedu/marble/src/lib/gps/PositionTracking.h 1147288 
>   /trunk/KDE/kdeedu/marble/src/lib/gps/PositionTracking.cpp 1147288 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/geodata/GeoRendererPlugin.cpp 1147288 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/geodata/GeoRendererView.h 1147288 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/geodata/GeoRendererView.cpp 1147288 
>   /trunk/KDE/kdeedu/marble/tests/TestGeoData.cpp 1147288 
> 
> Diff: http://reviewboard.kde.org/r/4285/diff
> 
> 
> Testing
> -------
> 
> Run TestGeoData :(
> 
> 
> Thanks,
> 
> Thibaut
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20100715/16b3a61f/attachment.htm