[Marble-devel] Review Request: Do not use cache for the overview map

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2715/#review3835
-----------------------------------------------------------



/trunk/KDE/kdeedu/marble/src/plugins/render/overviewmap/OverviewMap.cpp
<http://reviewboard.kde.org/r/2715/#comment3227>

    ... and (2) is the reason why it should be solved like this (and not by removing the "duplicated" m_worldmap pixmap in the rest of the overview map code). Sounds reasonable.
    
    


- Torsten


On 2010-01-24 08:34:01, Ariya Hidayat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2715/
> -----------------------------------------------------------
> 
> (Updated 2010-01-24 08:34:01)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> Because of the dynamic nature of the overview map during animation/navigation, caching the item in a pixmap will just put additional burden. Beside, the SVG object is already rendered and stored in a pixmap anyway.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/overviewmap/OverviewMap.cpp 1079360 
> 
> Diff: http://reviewboard.kde.org/r/2715/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ariya
> 
>