[Marble-devel] Review Request: Support adding paint layers internally

[Torsten Rahn]

> On 2010-02-20 10:03:49, Michael Hansen wrote:
> > I was also looking for a way to paint on different layers so I wrote this patch some time ago: http://reviewboard.kde.org/r/2227/
> > But I think your approach is much easier to work with.
> > 
> > Michael

Aren't those separate issues? I think your patch would make sense even with Dennis' patch included. Didn't your patch end up in trunk? :-/ I think it should have gone into trunk.


- Torsten


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3017/#review4223
-----------------------------------------------------------


On 2010-02-19 20:20:45, Dennis Nienhüser wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3017/
> -----------------------------------------------------------
> 
> (Updated 2010-02-19 20:20:45)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> Currently RenderPlugins can add layers which are then rendered according to their preference. This patch makes it possible to also create such layers internally (i.e. one does not need to create a plugin to create a paint layer). This is useful as a more powerful customPaint() alternative for people using MarbleWidget in their application (benefits: no need to derive from MarbleWidget, convenient access to ViewportParams). Additionally I'm using it to create the layer showing a route between two points (patch for that coming soon).
> 
> I wasn't sure about the copyright header for the new class. Any hints?
> 
> 
> Diffs
> -----
> 
>   /src/lib/LayerInterface.h PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/LayerManager.h 1092331 
>   /trunk/KDE/kdeedu/marble/src/lib/LayerManager.cpp 1092331 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleModel.h 1092331 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleModel.cpp 1092331 
>   /trunk/KDE/kdeedu/marble/src/lib/RenderPluginInterface.h 1092331 
> 
> Diff: http://reviewboard.kde.org/r/3017/diff
> 
> 
> Testing
> -------
> 
> Patch is based on my local branch where I'm using it to add an interactive layer for routing
> 
> 
> Thanks,
> 
> Dennis
> 
>