[Marble-devel] Re: Review Request: use scaled pixmap cache

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6250/#review9482
-----------------------------------------------------------

Ship it!


Looks good. Tested it on the N900 again, works fine and results in a much improved (~ twice as fast) panning behavior.


/branches/KDE/4.6/kdeedu/marble/src/lib/TextureColorizer.h
<http://svn.reviewboard.kde.org/r/6250/#comment10492>

    Should be explicit now


- Dennis


On 2010-12-31 15:46:04, Bernhard Beschow wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6250/
> -----------------------------------------------------------
> 
> (Updated 2010-12-31 15:46:04)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> This patch is an attempt to accellerate the tile-scaling approach even further using cached QPixmaps.
> 
> Note that this patch is claimed to be binary compatible to KDE 4.6 (Marble 1.0).
> 
> 
> Diffs
> -----
> 
>   /branches/KDE/4.6/kdeedu/marble/src/lib/AbstractScanlineTextureMapper.h 1210469 
>   /branches/KDE/4.6/kdeedu/marble/src/lib/EquirectScanlineTextureMapper.h 1210469 
>   /branches/KDE/4.6/kdeedu/marble/src/lib/EquirectScanlineTextureMapper.cpp 1210469 
>   /branches/KDE/4.6/kdeedu/marble/src/lib/MercatorScanlineTextureMapper.h 1210469 
>   /branches/KDE/4.6/kdeedu/marble/src/lib/MercatorScanlineTextureMapper.cpp 1210469 
>   /branches/KDE/4.6/kdeedu/marble/src/lib/SphericalScanlineTextureMapper.h 1210469 
>   /branches/KDE/4.6/kdeedu/marble/src/lib/SphericalScanlineTextureMapper.cpp 1210469 
>   /branches/KDE/4.6/kdeedu/marble/src/lib/StackedTileLoader.h 1210469 
>   /branches/KDE/4.6/kdeedu/marble/src/lib/StackedTileLoader.cpp 1210469 
>   /branches/KDE/4.6/kdeedu/marble/src/lib/TextureColorizer.h 1210469 
>   /branches/KDE/4.6/kdeedu/marble/src/lib/TextureColorizer.cpp 1210469 
>   /branches/KDE/4.6/kdeedu/marble/src/lib/TextureLayer.cpp 1210469 
>   /branches/KDE/4.6/kdeedu/marble/src/lib/TileScalingTextureMapper.h 1210469 
>   /branches/KDE/4.6/kdeedu/marble/src/lib/TileScalingTextureMapper.cpp 1210469 
> 
> Diff: http://svn.reviewboard.kde.org/r/6250/diff
> 
> 
> Testing
> -------
> 
> * I get ~4x speedups on my system (up to 130 fps with --timedemo, depending on the map theme)
> * Earthwings measured ~2x speedup on the N900 (up to 5.9 fps with --timedemo)
> 
> 
> Thanks,
> 
> Bernhard
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20101231/ee682eb6/attachment-0001.htm