[Marble-devel] Re: Review Request: Make the Position Marker plugin configurable by adding a settings page

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6232/#review9471
-----------------------------------------------------------



/trunk/KDE/kdeedu/marble/src/plugins/render/positionmarker/PositionMarker.cpp
<http://svn.reviewboard.kde.org/r/6232/#comment10480>

    Ooops, you forgot to read in:
    * The value for the m_useCustomCursor value
    * The Url of the pixmap
    ... from the settings object.
    Please add this to your next patch.



/trunk/KDE/kdeedu/marble/src/plugins/render/positionmarker/PositionMarker.cpp
<http://svn.reviewboard.kde.org/r/6232/#comment10481>

    Same problem as with the readSettings method: nothing is retrieved from the settings object ...Have a look at other plugins how this works.



/trunk/KDE/kdeedu/marble/src/plugins/render/positionmarker/PositionMarker.cpp
<http://svn.reviewboard.kde.org/r/6232/#comment10482>

    When doing scaling you should ensure that you're using "SmoothScaling" if possible. I've adjusted this in the commit already.


- Torsten


On 2010-12-29 23:46:50, Daniel Marth wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6232/
> -----------------------------------------------------------
> 
> (Updated 2010-12-29 23:46:50)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> Adds a configuration dialog to the position marker plugin to load a custom image as marker.
> GCI task: http://www.google-melange.com/gci/task/show/google/gci2010/kde/t129347413457
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/positionmarker/CMakeLists.txt 1210125 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/positionmarker/PositionMarker.h 1210125 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/positionmarker/PositionMarker.cpp 1210125 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/positionmarker/PositionMarkerConfigWidget.ui PRE-CREATION 
> 
> Diff: http://svn.reviewboard.kde.org/r/6232/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Daniel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20101230/f3709356/attachment-0001.htm