[Marble-devel] Re: Review Request: Make the Position Marker plugin configurable by adding a settings page

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6232/#review9466
-----------------------------------------------------------



/trunk/KDE/kdeedu/marble/src/plugins/render/positionmarker/PositionMarker.cpp
<http://svn.reviewboard.kde.org/r/6232/#comment10476>

    isn't this just the same as
    
    if ( rect.isValid() )
    
    ?



/trunk/KDE/kdeedu/marble/src/plugins/render/positionmarker/PositionMarker.cpp
<http://svn.reviewboard.kde.org/r/6232/#comment10475>

    I think the accuracy should still get shown even for a custom cursor.



/trunk/KDE/kdeedu/marble/src/plugins/render/positionmarker/PositionMarker.cpp
<http://svn.reviewboard.kde.org/r/6232/#comment10477>

    QPixmaps are implicitely shared, so creating them on the heap is a bit misleading. I suggest you create this member on the stack.


- Torsten


On 2010-12-29 16:04:42, Daniel Marth wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6232/
> -----------------------------------------------------------
> 
> (Updated 2010-12-29 16:04:42)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> Adds a configuration dialog to the position marker plugin to load a custom image as marker.
> GCI task: http://www.google-melange.com/gci/task/show/google/gci2010/kde/t129347413457
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/positionmarker/CMakeLists.txt 1209621 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/positionmarker/PositionMarker.h 1209621 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/positionmarker/PositionMarker.cpp 1209621 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/positionmarker/PositionMarkerConfigWidget.ui PRE-CREATION 
> 
> Diff: http://svn.reviewboard.kde.org/r/6232/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Daniel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20101229/d979f5fc/attachment.htm