[Marble-devel] Re: Review Request: Create a context menu for the scale bar plugin (not BC!)

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6226/#review9438
-----------------------------------------------------------

Ship it!


Looks great :)

- Torsten


On 2010-12-28 01:49:39, Daniel Marth wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6226/
> -----------------------------------------------------------
> 
> (Updated 2010-12-28 01:49:39)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> This is a better, but not BC solution to create context menus and tooltips for plugins. It creates a context menu for the scale bar plugin (see http://reviewboard.kde.org/r/6225/). Now the subclasses only need to implement the virtual methods contextMenuEvent() toolTipEvent() to react to the events.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/marble/src/lib/AbstractFloatItem.h 1209621 
>   /trunk/KDE/kdeedu/marble/src/lib/AbstractFloatItem.cpp 1209621 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/mapscale/MapScaleFloatItem.h 1209621 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/mapscale/MapScaleFloatItem.cpp 1209621 
> 
> Diff: http://svn.reviewboard.kde.org/r/6226/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Daniel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20101228/5c470d8a/attachment.htm