[Marble-devel] Re: Review Request: introduce optimized code path for Mercator projection

Bernhard Beschow bbeschow at cs.tu-berlin.de
Wed Dec 22 23:18:19 CET 2010



> On 2010-12-13 20:21:29, Torsten Rahn wrote:
> > /trunk/KDE/kdeedu/marble/src/lib/FastMercatorTextureMapper.cpp, line 85
> > <http://svn.reviewboard.kde.org/r/6109/diff/1/?file=42509#file42509line85>
> >
> >     This is very expensive. 
> >     - On one hand it would improve performance dramatically if you'd cache the scaled images.  
> >     - On one hand you're using QImage for scaling which is slower than QPixmap. 
> >     
> >     So ideally you'd create pixmaps from the original QImage tiles and then store the pixmaps in a hash which maps a key that consists of the tile_id + targetsize and you'd map that to the pixmap. This should improve performance dramatically.
> >
> 
> Bernhard Beschow wrote:
>     I haven't tried using a QPixmap but your suggestion sounds promising.
>     
>     As for the cache, I figure that each tile would need to be cached up to four times. The reason is that the target tile size probably oscillates by one pixel in each dimenstion when moving the map. Perhaps this could be prevented using QRectF.

Even if I cache all four tile sizes, the speed does not improve at all. In both cases I get 34-36fps.

Moreover, it looks like drawing QPixmaps onto QImages is very slow: I get ~20fps instead of ~36.


- Bernhard


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6109/#review9240
-----------------------------------------------------------


On 2010-12-13 23:46:02, Bernhard Beschow wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6109/
> -----------------------------------------------------------
> 
> (Updated 2010-12-13 23:46:02)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> This patch introduces an optimized code path for the case that both the tile projection and the map projection are of type Mercator. In this very common case, the tiles can be scaled rather than reprojected, promising a significant speedup. Moreover, it seems to avoid crashes in high zoom levels on the N900.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/marble/src/lib/AbstractScanlineTextureMapper.h 1205882 
>   /trunk/KDE/kdeedu/marble/src/lib/AbstractScanlineTextureMapper.cpp 1205882 
>   /trunk/KDE/kdeedu/marble/src/lib/CMakeLists.txt 1205882 
>   /trunk/KDE/kdeedu/marble/src/lib/FastMercatorTextureMapper.h PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/FastMercatorTextureMapper.cpp PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/TextureLayer.cpp 1205882 
> 
> Diff: http://svn.reviewboard.kde.org/r/6109/diff
> 
> 
> Testing
> -------
> 
> I have measured speedups of up to 2.7 on my system. This seems to depend on the QImage::Format, so format conversion should be avoided in a future version if possible.
> The image quality is roughly of outline quality when a discrete zoom level isn't hit.
> 
> I get crashes on my Netbook, but not on my other machine. The error message is: "QPaintDevice: Cannot destroy paint device that is being painted". I've got no idea what's going on here. Please help.
> 
> 
> Thanks,
> 
> Bernhard
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20101222/caae01f5/attachment.htm 


More information about the Marble-devel mailing list