[Marble-devel] Review Request: Inhibit screensaver without QtMobility

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6186/
-----------------------------------------------------------

Review request for marble.


Summary
-------

Currently on Maemo the screensaver gets inhibited on the N900 when GPS is active. This makes sense, but unfortunately the implementation (via QtMobility) forces a wakeup of the screen every thirty seconds. Therefore it's not possible to activate the screensaver manually if a user wants to (e.g. take the device with you for tracking), it will always wake up after a few seconds.

The patch removes the QtMobility dependency and uses DBus calls directly to inhibit the screensaver. In contrast to the prior implementation the user choice is not overriden.

Patch is for trunk but I intend to backport it to the 4.6 branch as well.


Diffs
-----

  /trunk/KDE/kdeedu/marble/FindQtsysteminfo.cmake 1208607 
  /trunk/KDE/kdeedu/marble/src/plugins/render/CMakeLists.txt 1208607 
  /trunk/KDE/kdeedu/marble/src/plugins/render/inhibit-screensaver/CMakeLists.txt 1208607 
  /trunk/KDE/kdeedu/marble/src/plugins/render/inhibit-screensaver/InhibitScreensaverPlugin.h 1208607 
  /trunk/KDE/kdeedu/marble/src/plugins/render/inhibit-screensaver/InhibitScreensaverPlugin.cpp 1208607 

Diff: http://svn.reviewboard.kde.org/r/6186/diff


Testing
-------

Tested on the N900.


Thanks,

Dennis

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20101222/80ea38b7/attachment.htm